fix: exception handling

Author: chrispader

example/src/tests/unitTests.spec.ts

@@ -560,8 +560,6 @@ export function registerUnitTests() {
         await promised
         expect.fail('Should not resolve')
       } catch (e) {
-        console.log(e)
-
         if (isError(e))
           expect(e.message).to.include('no such table: tableThatDoesNotExist')
         else expect.fail('Should have thrown a valid NitroSQLiteException')

package/cpp/NitroSQLiteException.hpp

@@ -28,15 +28,22 @@ inline std::string typeToString(NitroSQLiteExceptionType type) {
   return exceptionTypeStrings[type];
 }
 
-class NitroSQLiteException : public std::runtime_error {
+class NitroSQLiteException : public std::exception {
 public:
   explicit NitroSQLiteException(const char* message): NitroSQLiteException(NitroSQLiteExceptionType::UnknownError, message) {}
   explicit NitroSQLiteException(const std::string& message): NitroSQLiteException(NitroSQLiteExceptionType::UnknownError, message) {}
   NitroSQLiteException(const NitroSQLiteExceptionType& type, const char* message) : NitroSQLiteException(type, std::string(message)) {}
   NitroSQLiteException(const NitroSQLiteExceptionType& type, const std::string& message)
-    : std::runtime_error("[react-native-nitro-sqlite] " + typeToString(type) + ": " + message) {}
+    : _exceptionString("[" + typeToString(type) + "] " + message) {}
+
+private:
+  const std::string _exceptionString;
 
 public:
+  [[nodiscard]] const char* what() const noexcept override {
+    return this->_exceptionString.c_str();
+  }
+
   static NitroSQLiteException DatabaseNotOpen(const std::string& dbName) {
     return NitroSQLiteException(NitroSQLiteExceptionType::UnableToAttachToDatabase, dbName + " is not open");
   }