Skip to content

Commit ad9944b

Browse files
committed
chore: remove old architecture jobs
1 parent 59c8bce commit ad9944b

File tree

2 files changed

+4
-89
lines changed

2 files changed

+4
-89
lines changed

.github/workflows/build-android.yml

Lines changed: 2 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -27,52 +27,14 @@ on:
2727
- "**/nitro.json"
2828

2929
jobs:
30-
build_new:
31-
name: Build Android Example App (new architecture)
30+
build:
31+
name: Build Android Example App
3232
runs-on: ubuntu-latest
3333
steps:
3434
- uses: actions/checkout@v4
3535
- uses: oven-sh/setup-bun@v2
3636

3737
- name: Install npm dependencies (bun)
38-
run: bun install
39-
40-
- name: Setup JDK 17
41-
uses: actions/setup-java@v4
42-
with:
43-
distribution: "zulu"
44-
java-version: 17
45-
java-package: jdk
46-
47-
- name: Restore Gradle cache
48-
uses: actions/cache@v4
49-
with:
50-
path: |
51-
~/.gradle/caches
52-
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
53-
restore-keys: |
54-
${{ runner.os }}-gradle-
55-
- name: Run Gradle Build for example/android/
56-
working-directory: example/android
57-
run: ./gradlew assembleDebug --no-daemon --build-cache
58-
59-
# Gradle cache doesn't like daemons
60-
- name: Stop Gradle Daemon
61-
working-directory: example/android
62-
run: ./gradlew --stop
63-
64-
build_old:
65-
name: Build Android Example App (old architecture)
66-
runs-on: ubuntu-latest
67-
steps:
68-
- uses: actions/checkout@v4
69-
- uses: oven-sh/setup-bun@v2
70-
71-
- name: Install npm dependencies (bun)
72-
run: bun install
73-
74-
- name: Disable new architecture in gradle.properties
75-
run: sed -i "s/newArchEnabled=true/newArchEnabled=false/g" example/android/gradle.properties
7638

7739
- name: Setup JDK 17
7840
uses: actions/setup-java@v4

.github/workflows/build-ios.yml

Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ env:
3232
USE_CCACHE: 1
3333

3434
jobs:
35-
build_new:
36-
name: Build iOS Example App (new architecture)
35+
build:
36+
name: Build iOS Example App
3737
runs-on: macOS-15
3838
steps:
3939
- uses: actions/checkout@v4
@@ -74,50 +74,3 @@ jobs:
7474
-destination 'platform=iOS Simulator,name=iPhone 16' \
7575
build \
7676
CODE_SIGNING_ALLOWED=NO"
77-
78-
build_old:
79-
name: Build iOS Example App (old architecture)
80-
runs-on: macOS-15
81-
steps:
82-
- uses: actions/checkout@v4
83-
- uses: oven-sh/setup-bun@v2
84-
85-
- name: Install npm dependencies (bun)
86-
run: bun install
87-
88-
- name: Disable new architecture in Podfile
89-
run: sed -i "" "s/ENV\['RCT_NEW_ARCH_ENABLED'\] = '1'/ENV['RCT_NEW_ARCH_ENABLED'] = '0'/g" example/ios/Podfile
90-
91-
- name: Restore buildcache
92-
uses: mikehardy/buildcache-action@v2
93-
continue-on-error: true
94-
95-
- name: Setup Ruby (bundle)
96-
uses: ruby/setup-ruby@v1
97-
with:
98-
ruby-version: 2.7.2
99-
bundler-cache: true
100-
working-directory: example/ios
101-
102-
- name: Restore Pods cache
103-
uses: actions/cache@v4
104-
with:
105-
path: example/ios/Pods
106-
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
107-
restore-keys: |
108-
${{ runner.os }}-pods-
109-
- name: Install Pods
110-
working-directory: example/ios
111-
run: pod install
112-
- name: Build App
113-
working-directory: example/ios
114-
run: "set -o pipefail && xcodebuild \
115-
CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ \
116-
-derivedDataPath build -UseModernBuildSystem=YES \
117-
-workspace NitroSQLiteExample.xcworkspace \
118-
-scheme NitroSQLiteExample \
119-
-sdk iphonesimulator \
120-
-configuration Debug \
121-
-destination 'platform=iOS Simulator,name=iPhone 16' \
122-
build \
123-
CODE_SIGNING_ALLOWED=NO"

0 commit comments

Comments
 (0)