fix: promise rejections with error

Author: chrispader

bun.lockb

@@ -1885,7 +1885,7 @@ SPEC CHECKSUMS:
   fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be
   glog: 08b301085f15bcbb6ff8632a8ebaf239aae04e6a
   hermes-engine: 46f1ffbf0297f4298862068dd4c274d4ac17a1fd
-  NitroModules: d98cdb1eb0e7e6e88093b9b47134b99a31a70471
+  NitroModules: 1431939cc88ada3a3da108d11a293725d93e14c8
   RCT-Folly: bf5c0376ffe4dd2cf438dcf86db385df9fdce648
   RCTDeprecation: fde92935b3caa6cb65cbff9fbb7d3a9867ffb259
   RCTRequired: 75c6cee42d21c1530a6f204ba32ff57335d19007

example/ios/Podfile.lock

@@ -23,7 +23,7 @@
     "expo-status-bar": "^1.12.1",
     "react": "*",
     "react-native": "*",
-    "react-native-nitro-modules": "*",
+    "react-native-nitro-modules": "https://gitpkg.vercel.app/mrousavy/nitro/packages/react-native-nitro-modules?5334d8c902ea36d3f630be0c5b3e2e3ec5029661",
     "react-native-nitro-sqlite": "9.0.1",
     "react-native-safe-area-context": "^4.14.0",
     "react-native-screens": "^3.35.0",

example/package.json

@@ -559,6 +559,8 @@ export function registerUnitTests() {
         await promised
         expect.fail('Should not resolve')
       } catch (e) {
+        console.log(e)
+
         if (isError(e))
           expect(e.message).to.include('no such table: tableThatDoesNotExist')
         else expect.fail('Should have thrown a valid NitroSQLiteException')

example/src/tests/unitTests.spec.ts

@@ -31,7 +31,7 @@
     "patch-package": "^8.0.0",
     "react": "18.3.1",
     "react-native": "0.76.1",
-    "react-native-nitro-modules": "^0.17.0"
+    "react-native-nitro-modules": "https://gitpkg.vercel.app/mrousavy/nitro/packages/react-native-nitro-modules?5334d8c902ea36d3f630be0c5b3e2e3ec5029661"
   },
   "devDependencies": {
     "@babel/core": "^7.25.2",

package.json

@@ -61,12 +61,8 @@ ExecuteQueryResult HybridNitroSQLite::execute(const std::string& dbName, const s
 std::shared_ptr<Promise<std::shared_ptr<HybridNativeQueryResultSpec>>> HybridNitroSQLite::executeAsync(const std::string& dbName, const std::string& query,
                                                                                                        const std::optional<SQLiteQueryParams>& params) {
   return Promise<std::shared_ptr<HybridNativeQueryResultSpec>>::async([=, this]() -> std::shared_ptr<HybridNativeQueryResultSpec> {
-    try {
-      auto result = execute(dbName, query, params);
-      return result;
-    } catch (...) {
-      throw std::current_exception();
-    }
+    auto result = execute(dbName, query, params);
+    return result;
   });
 };
 
@@ -80,12 +76,8 @@ BatchQueryResult HybridNitroSQLite::executeBatch(const std::string& dbName, cons
 std::shared_ptr<Promise<BatchQueryResult>> HybridNitroSQLite::executeBatchAsync(const std::string& dbName,
                                                                                 const std::vector<BatchQueryCommand>& batchParams) {
   return Promise<BatchQueryResult>::async([=, this]() -> BatchQueryResult {
-    try {
-      auto result = executeBatch(dbName, batchParams);
-      return result;
-    } catch (...) {
-      throw std::current_exception();
-    }
+    auto result = executeBatch(dbName, batchParams);
+    return result;
   });
 };
 
@@ -96,12 +88,8 @@ FileLoadResult HybridNitroSQLite::loadFile(const std::string& dbName, const std:
 
 std::shared_ptr<Promise<FileLoadResult>> HybridNitroSQLite::loadFileAsync(const std::string& dbName, const std::string& location) {
   return Promise<FileLoadResult>::async([=, this]() -> FileLoadResult {
-    try {
-      auto result = loadFile(dbName, location);
-      return result;
-    } catch (...) {
-      throw std::current_exception();
-    }
+    auto result = loadFile(dbName, location);
+    return result;
   });
 };
 

package/cpp/specs/HybridNitroSQLite.cpp

@@ -74,7 +74,7 @@
     "react": "*",
     "react-native": "*",
     "react-native-builder-bob": "^0.31.0",
-    "react-native-nitro-modules": "*"
+    "react-native-nitro-modules": "https://gitpkg.vercel.app/mrousavy/nitro/packages/react-native-nitro-modules?5334d8c902ea36d3f630be0c5b3e2e3ec5029661"
   },
   "peerDependencies": {
     "react": ">=17.0.0",