chore: cleanup (#847)

Author: boorad

.claude/agents/cpp-specialist.md

@@ -1,6 +1,6 @@
 ---
 name: cpp-specialist
-description: Use PROACTIVELY for all C++ code, Nitro Modules implementation, OpenSSL 3.3+ integration, and native performance optimization
+description: Use PROACTIVELY for all C++ code, Nitro Modules implementation, OpenSSL 3.6+ integration, and native performance optimization
 ---
 
 # C++ Implementation Specialist
@@ -11,7 +11,7 @@ You are a C++ specialist focused on the native layer of React Native Quick Crypt
 
 - C++20 modern code
 - Nitro Modules native implementation
-- OpenSSL 3.3+ integration
+- OpenSSL 3.6+ integration
 - Native cryptographic operations
 - Memory management with smart pointers
 - Performance optimization
@@ -37,13 +37,13 @@ You are a C++ specialist focused on the native layer of React Native Quick Crypt
    // ... forget to free
    ```
 
-2. **OpenSSL 3.3+ APIs**
+2. **OpenSSL 3.6+ APIs**
    - Use EVP_* high-level APIs (not deprecated low-level)
    - Proper error handling with ERR_get_error()
    - Provider-based architecture where applicable
    - Check Node.js `deps/ncrypto` for reference patterns
    ```cpp
-   // GOOD: OpenSSL 3.3 EVP API
+   // GOOD: OpenSSL 3.6+ EVP API
    EVP_CIPHER_CTX* ctx = EVP_CIPHER_CTX_new();
    EVP_EncryptInit_ex2(ctx, EVP_aes_256_gcm(), key, iv, nullptr);
 
@@ -105,19 +105,13 @@ When implementing features, check in order:
 
 1. **Node.js ncrypto** (primary reference)
    - `$REPOS/node/deps/ncrypto` - Node.js externalized crypto
-   - May need updating to OpenSSL 3.3+ patterns
+   - May need updating to OpenSSL 3.6+ patterns
    - Best source for algorithm implementations
 
-2. **OpenSSL 3.3+ Documentation**
+2. **OpenSSL 3.6+ Documentation**
    - EVP API documentation
-   - Migration guide from 1.1.1 to 3.3+
    - Provider API for modern patterns
 
-3. **RNQC 0.x** (migration reference only)
-   - `$REPOS/rnqc/0.x` - Old implementation
-   - Uses OpenSSL 1.1.1 (deprecated)
-   - Don't copy patterns, use for comparison only
-
 ## Common Patterns
 
 ### Pattern 1: EVP Cipher Context (AEAD)
@@ -269,17 +263,6 @@ public:
 } // namespace
 ```
 
-## Migration from OpenSSL 1.1.1 to 3.3+
-
-Common changes needed:
-
-| OpenSSL 1.1.1 | OpenSSL 3.3+ |
-|---------------|-------------|
-| `AES_set_encrypt_key()` | `EVP_EncryptInit_ex2()` with `EVP_aes_*()` |
-| `SHA256()` | `EVP_Digest()` with `EVP_sha256()` |
-| Direct struct access | Use EVP getters/setters |
-| Low-level APIs | High-level EVP APIs |
-
 ## Quality Checks
 
 Before marking task complete:
@@ -291,7 +274,7 @@ Before marking task complete:
    - [ ] No raw pointer ownership
 
 2. **OpenSSL Integration**
-   - [ ] Using OpenSSL 3.3+ APIs
+   - [ ] Using OpenSSL 3.6+ APIs
    - [ ] No deprecated functions
    - [ ] Proper error handling
    - [ ] Error queue cleared
@@ -311,10 +294,9 @@ Before marking task complete:
 ## Tools & References
 
 - C++20 compiler
-- OpenSSL 3.3+ headers and libraries
+- OpenSSL 3.6+ headers and libraries
 - Nitro Modules SDK
 - Node.js ncrypto source (`$REPOS/node/deps/ncrypto`)
-- RNQC 0.x reference (`$REPOS/rnqc/0.x`)
 
 ## Collaboration
 
@@ -323,4 +305,4 @@ You work closely with:
 - **crypto-specialist**: Validate algorithm implementations
 - **testing-specialist**: Provide testable native APIs
 
-Remember: Write modern, safe, efficient C++ that properly integrates OpenSSL 3.3+ cryptographic operations into React Native via Nitro Modules.
+Remember: Write modern, safe, efficient C++ that properly integrates OpenSSL 3.6+ cryptographic operations into React Native via Nitro Modules.

.claude/agents/crypto-specialist.md

@@ -229,12 +229,12 @@ When reviewing a cryptographic implementation:
 
 ## Tools & References
 
-- OpenSSL documentation (v3.3+)
+- OpenSSL documentation (v3.6+)
 - NIST cryptographic standards
 - RFC specifications
 - WebCrypto API spec (W3C)
 - Node.js ncrypto source (`$REPOS/node/deps/ncrypto`)
-- RNQC 0.x for compatibility (`$REPOS/rnqc/0.x`)
+- ncrypto (`$REPOS/ncrypto`)
 
 ## Common Questions to Ask
 

.claude/agents/orchestrator.md

@@ -47,7 +47,7 @@ When you receive a request:
 
 4. **Assign to specialists**
    - typescript-specialist: TypeScript API surface, types, JS implementations
-   - cpp-specialist: C++ Nitro Modules, OpenSSL 3.3+ integration, native code
+   - cpp-specialist: C++ Nitro Modules, OpenSSL 3.6+ integration, native code
    - crypto-specialist: Cryptographic correctness, algorithm implementation, security
    - testing-specialist: Test strategies (note: tests run in RN app environment)
 
@@ -58,7 +58,7 @@ When you receive a request:
 User Request: "Implement subtle.encrypt/decrypt for AES-GCM"
 
 Orchestrator analyzes:
-- Scope: TypeScript API, C++ implementation, OpenSSL 3.3+
+- Scope: TypeScript API, C++ implementation, OpenSSL 3.6+
 - Requires: Type definitions, native implementation, bridging
 
 Decomposition:
@@ -67,7 +67,7 @@ Wave 1 (Foundation):
   - typescript-specialist: Define TypeScript types matching WebCrypto API
 
 Wave 2 (Implementation):
-  - cpp-specialist: Implement AES-GCM using OpenSSL 3.3+ EVP APIs
+  - cpp-specialist: Implement AES-GCM using OpenSSL 3.6+ EVP APIs
   - typescript-specialist: Create Nitro Module bindings
 
 Wave 3 (Validation):
@@ -77,7 +77,7 @@ Wave 3 (Validation):
 
 ### Example 2: Refactoring to Modern C++
 ```
-User Request: "Migrate hash functions from OpenSSL 1.1.1 to 3.3+"
+User Request: "Migrate hash functions from OpenSSL 1.1.1 to 3.6+"
 
 Orchestrator analyzes:
 - Scope: Multiple C++ files, OpenSSL API changes
@@ -86,7 +86,7 @@ Orchestrator analyzes:
 Decomposition:
 Wave 1 (Research):
   - cpp-specialist: Identify all OpenSSL 1.1.1 usage patterns
-  - crypto-specialist: Map deprecated APIs to OpenSSL 3.3+ equivalents
+  - crypto-specialist: Map deprecated APIs to OpenSSL 3.6+ equivalents
 
 Wave 2 (Migration):
   - cpp-specialist: Update to EVP_* APIs, modernize C++ patterns
@@ -110,7 +110,7 @@ Wave 1 (Specification):
   - typescript-specialist: Define TypeScript API matching Node.js
 
 Wave 2 (Implementation):
-  - cpp-specialist: Implement using OpenSSL 3.3+ PBKDF2
+  - cpp-specialist: Implement using OpenSSL 3.6+ PBKDF2
   - typescript-specialist: Create JS wrapper with Node.js semantics
 
 Wave 3 (Compatibility):

.claude/agents/typescript-specialist.md

@@ -53,8 +53,8 @@ You are a TypeScript specialist focused on the JavaScript/TypeScript layer of Re
 3. **API Compatibility Priority**
    - WebCrypto API first (for subtle.* methods)
    - Node.js API second (for crypto.* polyfills)
-   - 0.x compatibility third (for migration)
-   - Check Node.js `deps/ncrypto` for reference implementations
+   - ncrypto compatibility third (for working w/ OpenSSL)
+   - Check Node.js's separate repo `$REPOS/ncrypto` for reference implementations
 
 **HIGH - ENFORCE STRICTLY:**
 
@@ -125,11 +125,6 @@ When implementing features, check in order:
 2. **Node.js** (for `crypto.*` polyfills)
    - `$REPOS/node/deps/ncrypto` - Node.js crypto externalization
    - Node.js crypto module documentation
-   - May need updating to OpenSSL 3.3+
-
-3. **RNQC 0.x** (for migration reference)
-   - `$REPOS/rnqc/0.x` - Old implementation
-   - Uses OpenSSL 1.1.1 (deprecated patterns)
 
 ## Common Patterns
 

.claude/rules/architecture.xml

@@ -10,7 +10,6 @@
       <item>This is a React Native project that offers cryptographic operations in native code</item>
       <item>Uses Nitro Modules to bridge JavaScript and C++</item>
       <item>Part of the API strives to be a polyfill of the Node.js crypto module</item>
-      <item>Goal: Migrate from OpenSSL 1.1.1 to OpenSSL 3.3+ with modern C++ and Nitro Modules</item>
     </context>
     <mustAcknowledge>true</mustAcknowledge>
   </rule>
@@ -30,12 +29,12 @@
     </priority>
     <priority>
       <rank>3</rank>
-      <source>RNQC 0.x Implementation</source>
-      <rationale>Legacy reference at $REPOS/rnqc/0.x (uses OpenSSL 1.1.1, deprecated)</rationale>
+      <source>ncrypto Implementation</source>
+      <rationale>reference at $REPOS/ncrypto (now a separate repo from nodejs)</rationale>
     </priority>
     <mustAcknowledge>true</mustAcknowledge>
     <instructions>
-      Always check Node.js deps/ncrypto before implementing new features. It may need upgrading to OpenSSL 3.3+ patterns.
+      Always check Node.js deps/ncrypto before implementing new features. It may need upgrading to OpenSSL 3.6+ patterns.
     </instructions>
   </rule>
 
@@ -47,8 +46,8 @@
       <tool>TypeScript - Type system</tool>
       <tool>Nitro Modules - Native bridging</tool>
       <tool>C++20 or higher - Modern C++</tool>
-      <tool>OpenSSL 3.3+ - Cryptographic library</tool>
-      <tool>Bun 1.2+ - TypeScript package manager</tool>
+      <tool>OpenSSL 3.6+ - Cryptographic library</tool>
+      <tool>Bun 1.3+ - TypeScript package manager</tool>
     </stack>
     <instructions>
       Use modern features from each technology. No legacy patterns.
@@ -87,16 +86,16 @@
       <reference>
         <path>$REPOS/node</path>
         <description>Node.js source code</description>
-        <focus>deps/ncrypto - Externalized crypto code, use as reference for implementations</focus>
+        <focus>use as reference for crypto/subtle implementations</focus>
       </reference>
       <reference>
-        <path>$REPOS/rnqc/0.x</path>
-        <description>RNQC 0.x legacy branch</description>
-        <focus>Uses OpenSSL 1.1.1 - migration reference only, don't copy patterns</focus>
+        <path>$REPOS/ncrypto</path>
+        <description>ncrypto sharable library used by Node.js</description>
+        <focus>Abstracts OpenSSL calls and utilities from Node.js code</focus>
       </reference>
     </references>
     <instructions>
-      Update this library's copy of ncrypto patterns occasionally when implementing new features.
+      Update this library's submodule of ncrypto occasionally when implementing new features.
     </instructions>
   </rule>
 

.claude/rules/code-cpp.xml

@@ -45,8 +45,8 @@
   </rule>
 
   <rule severity="CRITICAL" enforcement="BLOCKING">
-    <name>OpenSSL 3.3+ APIs Only</name>
-    <description>Use OpenSSL 3.3+ or higher EVP APIs, no deprecated functions</description>
+    <name>OpenSSL 3.6+ APIs Only</name>
+    <description>Use OpenSSL 3.6+ or higher EVP APIs, no deprecated functions</description>
     <requirements>
       <requirement>EVP high-level APIs only</requirement>
       <requirement>No low-level deprecated APIs (AES_*, SHA256_*, etc.)</requirement>
@@ -69,7 +69,7 @@
     </migrations>
     <mustAcknowledge>true</mustAcknowledge>
     <rationale>
-      OpenSSL 1.1.1 is deprecated. OpenSSL 3.x provides better security, performance, and future support.
+      OpenSSL 3.6+ provides better security, performance, and future support.
     </rationale>
   </rule>
 
@@ -146,18 +146,12 @@
         <name>Node.js ncrypto</name>
         <path>$REPOS/node/deps/ncrypto</path>
         <description>Node.js externalized crypto code - primary reference</description>
-        <note>May need updating to OpenSSL 3.3+ patterns</note>
+        <note>May need updating to OpenSSL 3.6+ patterns</note>
       </source>
       <source priority="2">
-        <name>OpenSSL 3.3+ Documentation</name>
+        <name>OpenSSL 3.6+ Documentation</name>
         <description>Official OpenSSL API documentation and migration guides</description>
       </source>
-      <source priority="3">
-        <name>RNQC 0.x</name>
-        <path>$REPOS/rnqc/0.x</path>
-        <description>Legacy implementation - migration reference only</description>
-        <warning>Uses OpenSSL 1.1.1 - don't copy patterns directly</warning>
-      </source>
     </sources>
   </rule>
 
@@ -182,7 +176,7 @@
       <setting>C++20 minimum standard</setting>
       <setting>Enable all warnings (-Wall -Wextra)</setting>
       <setting>Treat warnings as errors</setting>
-      <setting>Link against OpenSSL 3.3+</setting>
+      <setting>Link against OpenSSL 3.6+</setting>
     </settings>
   </rule>
 

CLAUDE.md

@@ -15,7 +15,7 @@ This project uses the **4-Layer Orchestra Architecture** for efficient multi-age
 When implementing features, favor in this order:
 1. **WebCrypto API** - Modern standard, best for `subtle.*` methods
 2. **Node.js Implementation** - Use `$REPOS/node/deps/ncrypto` as reference
-3. **RNQC 0.x** - Legacy reference at `$REPOS/rnqc/0.x` (OpenSSL 1.1.1, deprecated)
+3. **ncrypto** - submodule code reference at `$REPOS/ncrypto` (do work w/ OpenSSL)
 
 **Always check Node.js `deps/ncrypto` before implementing new features.**
 
@@ -24,8 +24,8 @@ When implementing features, favor in this order:
 - **TypeScript** - Type system (strict mode, no `any`)
 - **Nitro Modules** - Native bridging
 - **C++20 or higher** - Modern C++ (smart pointers, RAII)
-- **OpenSSL 3.3+** - Cryptographic library (EVP APIs only)
-- **Bun 1.2+** - TypeScript package manager
+- **OpenSSL 3.6+** - Cryptographic library (EVP APIs only)
+- **Bun 1.3+** - TypeScript package manager
 
 ### 3. Code Philosophy
 - Minimize code rather than add more
@@ -40,26 +40,13 @@ When implementing features, favor in this order:
 - No key material in errors/logs
 - Validate against test vectors (NIST, RFC, Node.js)
 
-## Project Structure
-
-```
-react-native-quick-crypto/
-├── src/                  # TypeScript source
-├── cpp/                  # C++ native implementation
-├── example/              # React Native test app
-│
-├── .claude/              # Orchestration configuration
-    ├── agents/           # Specialist agent definitions
-    └── rules/            # XML rules for context management
-```
-
 ## Rules Summary
 
 For full details, see `.claude/rules/*.xml`:
 
 ### architecture.xml
 - Project context and goals
-- API priority order (WebCrypto → Node.js → 0.x)
+- API priority order (WebCrypto → Node.js → ncrypto)
 - Tech stack requirements
 - Code philosophy
 - Testing context (RN environment)
@@ -77,7 +64,7 @@ For full details, see `.claude/rules/*.xml`:
 ### code-cpp.xml
 - C++20 minimum with modern features
 - Smart pointers for all ownership
-- OpenSSL 3.3+ EVP APIs only (no deprecated)
+- OpenSSL 3.6+ EVP APIs only (no deprecated)
 - RAII for all resources
 - Proper error handling (ERR_get_error)
 - Memory safety (no leaks, no raw ownership)
@@ -119,11 +106,11 @@ Use these instead of web searches:
 
 - **Node.js**: `$REPOS/node`
   - `deps/ncrypto` - Use as bible for crypto operations
-  - May need updating to OpenSSL 3.3+ patterns
+  - May need updating to OpenSSL 3.6+ patterns
 
-- **RNQC 0.x**: `$REPOS/rnqc/0.x`
-  - Legacy branch (OpenSSL 1.1.1)
-  - Migration reference only, don't copy patterns
+- **ncrypto**: `$REPOS/ncrypto`
+  - separate crypto lib broken out from Node.js
+  - Patterns and tools to access OpenSSL
 
 ## Testing
 

README.md

@@ -10,7 +10,7 @@
 
 A fast implementation of Node's `crypto` module.
 
-> Note: This version `1.x` completed a major refactor, porting to OpenSSL 3.3+, New Architecture, Bridgeless, and [`Nitro Modules`](https://github.com/mrousavy/react-native-nitro).  It should be at or above feature-parity compared to the `0.x` version.  Status, as always, will be represented in [implementation-coverage.md](../main/docs/implementation-coverage.md).
+> Note: This version `1.x` completed a major refactor, porting to OpenSSL 3.6+, New Architecture, Bridgeless, and [`Nitro Modules`](https://github.com/mrousavy/react-native-nitro).  It should be at or above feature-parity compared to the `0.x` version.  Status, as always, will be represented in [implementation-coverage.md](../main/docs/implementation-coverage.md).
 
 > Note: Minimum supported version of React Native is `0.75`.  If you need to use earlier versions, please use `0.x` versions of this library.