Skip to content

Commit 0875a70

Browse files
philmdbonzini
authored andcommitted
target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c
Move qmp_query_sev_launch_measure() from monitor.c to sev.c and make sev_get_launch_measurement() static. We don't need the stub anymore, remove it. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 8371df2 commit 0875a70

File tree

4 files changed

+20
-21
lines changed

4 files changed

+20
-21
lines changed

target/i386/monitor.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -710,23 +710,6 @@ void hmp_info_sev(Monitor *mon, const QDict *qdict)
710710
qapi_free_SevInfo(info);
711711
}
712712

713-
SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
714-
{
715-
char *data;
716-
SevLaunchMeasureInfo *info;
717-
718-
data = sev_get_launch_measurement();
719-
if (!data) {
720-
error_setg(errp, "SEV launch measurement is not available");
721-
return NULL;
722-
}
723-
724-
info = g_malloc0(sizeof(*info));
725-
info->data = data;
726-
727-
return info;
728-
}
729-
730713
SGXInfo *qmp_query_sgx(Error **errp)
731714
{
732715
return sgx_get_info(errp);

target/i386/sev-sysemu-stub.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ SevInfo *sev_get_info(void)
2222
return NULL;
2323
}
2424

25-
char *sev_get_launch_measurement(void)
25+
SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
2626
{
27+
error_setg(errp, "SEV is not available in this QEMU");
2728
return NULL;
2829
}
2930

target/i386/sev.c

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -742,8 +742,7 @@ sev_launch_get_measure(Notifier *notifier, void *unused)
742742
trace_kvm_sev_launch_measurement(sev->measurement);
743743
}
744744

745-
char *
746-
sev_get_launch_measurement(void)
745+
static char *sev_get_launch_measurement(void)
747746
{
748747
if (sev_guest &&
749748
sev_guest->state >= SEV_STATE_LAUNCH_SECRET) {
@@ -753,6 +752,23 @@ sev_get_launch_measurement(void)
753752
return NULL;
754753
}
755754

755+
SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
756+
{
757+
char *data;
758+
SevLaunchMeasureInfo *info;
759+
760+
data = sev_get_launch_measurement();
761+
if (!data) {
762+
error_setg(errp, "SEV launch measurement is not available");
763+
return NULL;
764+
}
765+
766+
info = g_malloc0(sizeof(*info));
767+
info->data = data;
768+
769+
return info;
770+
}
771+
756772
static Notifier sev_machine_done_notify = {
757773
.notify = sev_launch_get_measure,
758774
};

target/i386/sev.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ bool sev_es_enabled(void);
5050
extern SevInfo *sev_get_info(void);
5151
extern uint32_t sev_get_cbit_position(void);
5252
extern uint32_t sev_get_reduced_phys_bits(void);
53-
extern char *sev_get_launch_measurement(void);
5453
extern bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp);
5554

5655
int sev_encrypt_flash(uint8_t *ptr, uint64_t len, Error **errp);

0 commit comments

Comments
 (0)