Skip to content

Commit 243a928

Browse files
dagrhmstsirkin
authored andcommitted
virtio-balloon: Fix page-poison subsection name
The subsection name for page-poison was typo'd as: vitio-balloon-device/page-poison Note the missing 'r' in virtio. When we have a machine type that enables page poison, and the guest enables it (which needs a new kernel), things fail rather unpredictably. The fallout from this is that most of the other subsections fail to load, including things like the feature bits in the device, one possible fallout is that the physical addresses of the queues then get aligned differently and we fail with an error about last_avail_idx being wrong. It's not obvious to me why this doesn't produce a more obvious failure, but virtio's vmstate loading is a bit open-coded. Fixes: 7483cbb ("virtio-balloon: Implement support for page poison reporting feature") bz: https://bugzilla.redhat.com/show_bug.cgi?id=1984401 Signed-off-by: Dr. David Alan Gilbert <[email protected]> Message-Id: <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: David Hildenbrand <[email protected]>
1 parent 500eb21 commit 243a928

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

hw/virtio/virtio-balloon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ static const VMStateDescription vmstate_virtio_balloon_free_page_hint = {
852852
};
853853

854854
static const VMStateDescription vmstate_virtio_balloon_page_poison = {
855-
.name = "vitio-balloon-device/page-poison",
855+
.name = "virtio-balloon-device/page-poison",
856856
.version_id = 1,
857857
.minimum_version_id = 1,
858858
.needed = virtio_balloon_page_poison_support,

0 commit comments

Comments
 (0)