Skip to content

Commit 24b861c

Browse files
Vladimir Sementsov-OgievskiyXanClic
authored andcommitted
iotests: don't test qcow2.py inside 291
820c6be added testing of qcow2.py into 291, and it breaks 291 with external data file. Actually, 291 is bad place for qcow2.py testing, better add a separate test. For now, drop qcow2.py testing from 291 to fix the regression. Fixes: 820c6be Reported-by: Max Reitz <[email protected]> Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Max Reitz <[email protected]>
1 parent e11543c commit 24b861c

File tree

2 files changed

+0
-37
lines changed

2 files changed

+0
-37
lines changed

tests/qemu-iotests/291

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ $QEMU_IO -c 'w 1M 1M' -f $IMGFMT "$TEST_IMG" | _filter_qemu_io
6464
$QEMU_IMG bitmap --disable -f $IMGFMT "$TEST_IMG" b1
6565
$QEMU_IMG bitmap --enable -f $IMGFMT "$TEST_IMG" b2
6666
$QEMU_IO -c 'w 2M 1M' -f $IMGFMT "$TEST_IMG" | _filter_qemu_io
67-
echo "Check resulting qcow2 header extensions:"
68-
$PYTHON qcow2.py "$TEST_IMG" dump-header-exts
6967

7068
echo
7169
echo "=== Bitmap preservation not possible to non-qcow2 ==="
@@ -92,8 +90,6 @@ $QEMU_IMG bitmap --merge tmp -f $IMGFMT "$TEST_IMG" b0
9290
$QEMU_IMG bitmap --remove --image-opts \
9391
driver=$IMGFMT,file.driver=file,file.filename="$TEST_IMG" tmp
9492
_img_info --format-specific
95-
echo "Check resulting qcow2 header extensions:"
96-
$PYTHON qcow2.py "$TEST_IMG" dump-header-exts
9793

9894
echo
9995
echo "=== Check bitmap contents ==="

tests/qemu-iotests/291.out

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,6 @@ wrote 1048576/1048576 bytes at offset 1048576
1414
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
1515
wrote 1048576/1048576 bytes at offset 2097152
1616
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
17-
Check resulting qcow2 header extensions:
18-
Header extension:
19-
magic 0xe2792aca (Backing format)
20-
length 5
21-
data 'qcow2'
22-
23-
Header extension:
24-
magic 0x6803f857 (Feature table)
25-
length 336
26-
data <binary>
27-
28-
Header extension:
29-
magic 0x23852875 (Bitmaps)
30-
length 24
31-
nb_bitmaps 2
32-
reserved32 0
33-
bitmap_directory_size 0x40
34-
bitmap_directory_offset 0x510000
35-
3617

3718
=== Bitmap preservation not possible to non-qcow2 ===
3819

@@ -84,20 +65,6 @@ Format specific information:
8465
granularity: 65536
8566
refcount bits: 16
8667
corrupt: false
87-
Check resulting qcow2 header extensions:
88-
Header extension:
89-
magic 0x6803f857 (Feature table)
90-
length 336
91-
data <binary>
92-
93-
Header extension:
94-
magic 0x23852875 (Bitmaps)
95-
length 24
96-
nb_bitmaps 3
97-
reserved32 0
98-
bitmap_directory_size 0x60
99-
bitmap_directory_offset 0x520000
100-
10168

10269
=== Check bitmap contents ===
10370

0 commit comments

Comments
 (0)