Skip to content

Commit 2e79802

Browse files
committed
thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc
All the Coverity-specific definitions of qemu_mutex_lock() and friends have a trailing semicolon. This works fine almost everywhere because of QEMU's mandatory-braces coding style and because most callsites are simple, but target/s390x/sigp.c has a use of qemu_mutex_trylock() as an if() statement, which makes the ';' a syntax error: "../target/s390x/sigp.c", line 461: warning qemu#18: expected a ")" if (qemu_mutex_trylock(&qemu_sigp_mutex)) { ^ Remove the bogus semicolons from the macro definitions. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Message-id: [email protected]
1 parent 062c73c commit 2e79802

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

include/qemu/thread.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,17 @@ extern QemuCondTimedWaitFunc qemu_cond_timedwait_func;
5757
* hide them.
5858
*/
5959
#define qemu_mutex_lock(m) \
60-
qemu_mutex_lock_impl(m, __FILE__, __LINE__);
60+
qemu_mutex_lock_impl(m, __FILE__, __LINE__)
6161
#define qemu_mutex_trylock(m) \
62-
qemu_mutex_trylock_impl(m, __FILE__, __LINE__);
62+
qemu_mutex_trylock_impl(m, __FILE__, __LINE__)
6363
#define qemu_rec_mutex_lock(m) \
64-
qemu_rec_mutex_lock_impl(m, __FILE__, __LINE__);
64+
qemu_rec_mutex_lock_impl(m, __FILE__, __LINE__)
6565
#define qemu_rec_mutex_trylock(m) \
66-
qemu_rec_mutex_trylock_impl(m, __FILE__, __LINE__);
66+
qemu_rec_mutex_trylock_impl(m, __FILE__, __LINE__)
6767
#define qemu_cond_wait(c, m) \
68-
qemu_cond_wait_impl(c, m, __FILE__, __LINE__);
68+
qemu_cond_wait_impl(c, m, __FILE__, __LINE__)
6969
#define qemu_cond_timedwait(c, m, ms) \
70-
qemu_cond_timedwait_impl(c, m, ms, __FILE__, __LINE__);
70+
qemu_cond_timedwait_impl(c, m, ms, __FILE__, __LINE__)
7171
#else
7272
#define qemu_mutex_lock(m) ({ \
7373
QemuMutexLockFunc _f = atomic_read(&qemu_mutex_lock_func); \

0 commit comments

Comments
 (0)