Skip to content

Commit 323f984

Browse files
mcaylandvivier
authored andcommitted
mac_via: remove explicit viaN prefix from VIA IRQ gpios
Now that q800 VIA1 and VIA2 are completely separate devices there is no need to add a specific device prefix to ensure that the IRQ lines remain separate. Signed-off-by: Mark Cave-Ayland <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Message-Id: <[email protected]> Signed-off-by: Laurent Vivier <[email protected]>
1 parent 02a68a3 commit 323f984

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

hw/m68k/q800.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -377,12 +377,10 @@ static void q800_init(MachineState *machine)
377377

378378
sysbus = SYS_BUS_DEVICE(dev);
379379
sysbus_realize_and_unref(sysbus, &error_fatal);
380-
sysbus_connect_irq(sysbus, 0, qdev_get_gpio_in_named(via2_dev,
381-
"via2-irq",
382-
VIA2_IRQ_SCSI_BIT));
383-
sysbus_connect_irq(sysbus, 1,
384-
qdev_get_gpio_in_named(via2_dev, "via2-irq",
385-
VIA2_IRQ_SCSI_DATA_BIT));
380+
sysbus_connect_irq(sysbus, 0, qdev_get_gpio_in(via2_dev,
381+
VIA2_IRQ_SCSI_BIT));
382+
sysbus_connect_irq(sysbus, 1, qdev_get_gpio_in(via2_dev,
383+
VIA2_IRQ_SCSI_DATA_BIT));
386384
sysbus_mmio_map(sysbus, 0, ESP_BASE);
387385
sysbus_mmio_map(sysbus, 1, ESP_PDMA);
388386

hw/misc/mac_via.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,8 +1004,7 @@ static void mos6522_q800_via1_realize(DeviceState *dev, Error **errp)
10041004
v1s->tick_offset = (uint32_t)mktimegm(&tm) + RTC_OFFSET;
10051005

10061006
adb_register_autopoll_callback(adb_bus, adb_via_poll, v1s);
1007-
v1s->adb_data_ready = qdev_get_gpio_in_named(dev, "via1-irq",
1008-
VIA1_IRQ_ADB_READY_BIT);
1007+
v1s->adb_data_ready = qdev_get_gpio_in(dev, VIA1_IRQ_ADB_READY_BIT);
10091008

10101009
if (v1s->blk) {
10111010
int64_t len = blk_getlength(v1s->blk);
@@ -1042,8 +1041,7 @@ static void mos6522_q800_via1_init(Object *obj)
10421041
qbus_create_inplace((BusState *)&v1s->adb_bus, sizeof(v1s->adb_bus),
10431042
TYPE_ADB_BUS, DEVICE(v1s), "adb.0");
10441043

1045-
qdev_init_gpio_in_named(DEVICE(obj), via1_irq_request, "via1-irq",
1046-
VIA1_IRQ_NB);
1044+
qdev_init_gpio_in(DEVICE(obj), via1_irq_request, VIA1_IRQ_NB);
10471045
}
10481046

10491047
static const VMStateDescription vmstate_q800_via1 = {
@@ -1136,8 +1134,7 @@ static void mos6522_q800_via2_init(Object *obj)
11361134
"via2", VIA_SIZE);
11371135
sysbus_init_mmio(sbd, &v2s->via_mem);
11381136

1139-
qdev_init_gpio_in_named(DEVICE(obj), via2_irq_request, "via2-irq",
1140-
VIA2_IRQ_NB);
1137+
qdev_init_gpio_in(DEVICE(obj), via2_irq_request, VIA2_IRQ_NB);
11411138
}
11421139

11431140
static const VMStateDescription vmstate_q800_via2 = {

0 commit comments

Comments
 (0)