Skip to content

Commit 41977c6

Browse files
zbalatonkraxel
authored andcommitted
ati-vga: Do not assert on error
Do not abort on unsupported value just print log and continue. While display will likely be broken this prevents malicious guest to crash QEMU causing denial of service. Signed-off-by: BALATON Zoltan <[email protected]> Message-id: 0c13dab5d8e3b7e7479c3edbf53aeac8c09de6de.1592737958.git.balaton@eik.bme.hu Signed-off-by: Gerd Hoffmann <[email protected]>
1 parent d634c88 commit 41977c6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

hw/display/ati.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ static void ati_vga_switch_mode(ATIVGAState *s)
8686
break;
8787
default:
8888
qemu_log_mask(LOG_UNIMP, "Unsupported bpp value\n");
89+
return;
8990
}
90-
assert(bpp != 0);
9191
DPRINTF("Switching to %dx%d %d %d @ %x\n", h, v, stride, bpp, offs);
9292
vbe_ioport_write_index(&s->vga, 0, VBE_DISPI_INDEX_ENABLE);
9393
vbe_ioport_write_data(&s->vga, 0, VBE_DISPI_DISABLED);

0 commit comments

Comments
 (0)