Skip to content

Commit 458e056

Browse files
borntraegercohuck
authored andcommitted
docs/s390x: fix vfio-ap device_del description
device_del requires an id and not a sysfsfile. Fixes: bac03ec ("s390x/vfio-ap: document hot plug/unplug of vfio-ap device") Signed-off-by: Christian Borntraeger <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Message-Id: <[email protected]> [CH: add missing '$'] Signed-off-by: Cornelia Huck <[email protected]>
1 parent f030532 commit 458e056

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/system/s390x/vfio-ap.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -606,10 +606,11 @@ action.
606606

607607
To hot plug a vfio-ap device, use the QEMU ``device_add`` command::
608608

609-
(qemu) device_add vfio-ap,sysfsdev="$path-to-mdev"
609+
(qemu) device_add vfio-ap,sysfsdev="$path-to-mdev",id="$id"
610610

611611
Where the ``$path-to-mdev`` value specifies the absolute path to a mediated
612612
device to which AP resources to be used by the guest have been assigned.
613+
``$id`` is the name value for the optional id parameter.
613614

614615
Note that on Linux guests, the AP devices will be created in the
615616
``/sys/bus/ap/devices`` directory when the AP bus subsequently performs its periodic
@@ -632,10 +633,9 @@ or a prior hot plug action.
632633

633634
To hot unplug a vfio-ap device, use the QEMU ``device_del`` command::
634635

635-
(qemu) device_del vfio-ap,sysfsdev="$path-to-mdev"
636+
(qemu) device_del "$id"
636637

637-
Where ``$path-to-mdev`` is the same as the path specified when the vfio-ap
638-
device was attached to the virtual machine's ap-bus.
638+
Where ``$id`` is the same id that was specified at device creation.
639639

640640
On a Linux guest, the AP devices will be removed from the ``/sys/bus/ap/devices``
641641
directory on the guest when the AP bus subsequently performs its periodic scan,

0 commit comments

Comments
 (0)