Skip to content

Commit 4a40f56

Browse files
XanClicstsquad
authored andcommitted
iotests: Set LC_ALL=C for sort
Otherwise the result is basically unpredictable. (Note that the precise environment variable to control sorting order is LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the sorting order to be messed up if LC_ALL is set in the environment.) Reported-by: John Snow <[email protected]> Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Alex Bennée <[email protected]> Message-Id: <[email protected]>
1 parent e94f068 commit 4a40f56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/qemu-iotests/common.filter

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ _filter_img_create()
186186
-e 's/^\(data_file\)/3-\1/' \
187187
-e 's/^\(encryption\)/4-\1/' \
188188
-e 's/^\(preallocation\)/8-\1/' \
189-
| sort \
189+
| LC_ALL=C sort \
190190
| $SED -e 's/^[0-9]-//' \
191191
| tr '\n\0' ' \n' \
192192
| $SED -e 's/^ *$//' -e 's/ *$//'

0 commit comments

Comments
 (0)