macfb: add trace events for reading and writing the control registers

mcayland · vivier · commit 4ec27073fd0e · 2021-10-08T13:31:03.000+02:00
Signed-off-by: Mark Cave-Ayland &lt;mark.cave-ayland@ilande.co.uk&gt;
Reviewed-by: Philippe Mathieu-Daudé &lt;f4bug@amsat.org&gt;
Reviewed-by: Laurent Vivier &lt;laurent@vivier.eu&gt;
Message-Id: &lt;20211007221253.29024-7-mark.cave-ayland@ilande.co.uk&gt;
Signed-off-by: Laurent Vivier &lt;laurent@vivier.eu&gt;
diff --git a/hw/display/macfb.c b/hw/display/macfb.c
@@ -20,6 +20,7 @@
 #include "qapi/error.h"
 #include "hw/qdev-properties.h"
 #include "migration/vmstate.h"
+#include "trace.h"
 
 #define VIDEO_BASE 0x00001000
 #define DAFB_BASE  0x00800000
@@ -289,7 +290,10 @@ static uint64_t macfb_ctrl_read(void *opaque,
                                 hwaddr addr,
                                 unsigned int size)
 {
-    return 0;
+    uint64_t val = 0;
+
+    trace_macfb_ctrl_read(addr, val, size);
+    return val;
 }
 
 static void macfb_ctrl_write(void *opaque,
@@ -311,6 +315,8 @@ static void macfb_ctrl_write(void *opaque,
         }
         break;
     }
+
+    trace_macfb_ctrl_write(addr, val, size);
 }
 
 static const MemoryRegionOps macfb_ctrl_ops = {
diff --git a/hw/display/trace-events b/hw/display/trace-events
@@ -167,3 +167,7 @@ sm501_disp_ctrl_read(uint32_t addr, uint32_t val) "addr=0x%x, val=0x%x"
 sm501_disp_ctrl_write(uint32_t addr, uint32_t val) "addr=0x%x, val=0x%x"
 sm501_2d_engine_read(uint32_t addr, uint32_t val) "addr=0x%x, val=0x%x"
 sm501_2d_engine_write(uint32_t addr, uint32_t val) "addr=0x%x, val=0x%x"
+
+# macfb.c
+macfb_ctrl_read(uint64_t addr, uint64_t value, unsigned int size) "addr 0x%"PRIx64 " value 0x%"PRIx64 " size %u"
+macfb_ctrl_write(uint64_t addr, uint64_t value, unsigned int size) "addr 0x%"PRIx64 " value 0x%"PRIx64 " size %u"

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`#include "qapi/error.h"`
`21`	`21`	`#include "hw/qdev-properties.h"`
`22`	`22`	`#include "migration/vmstate.h"`
	`23`	`+#include "trace.h"`
`23`	`24`
`24`	`25`	`#define VIDEO_BASE 0x00001000`
`25`	`26`	`#define DAFB_BASE 0x00800000`
`@@ -289,7 +290,10 @@ static uint64_t macfb_ctrl_read(void *opaque,`
`289`	`290`	`hwaddr addr,`
`290`	`291`	`unsigned int size)`
`291`	`292`	`{`
`292`		`- return 0;`
	`293`	`+ uint64_t val = 0;`
	`294`	`+`
	`295`	`+ trace_macfb_ctrl_read(addr, val, size);`
	`296`	`+ return val;`
`293`	`297`	`}`
`294`	`298`
`295`	`299`	`static void macfb_ctrl_write(void *opaque,`
`@@ -311,6 +315,8 @@ static void macfb_ctrl_write(void *opaque,`
`311`	`315`	`}`
`312`	`316`	`break;`
`313`	`317`	`}`
	`318`	`+`
	`319`	`+ trace_macfb_ctrl_write(addr, val, size);`
`314`	`320`	`}`
`315`	`321`
`316`	`322`	`static const MemoryRegionOps macfb_ctrl_ops = {`