Skip to content

Commit 848dd26

Browse files
YananWang-hubvivier
authored andcommitted
qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2"
There is one numa config example in qemu-options.hx currently using "-smp 2" and assuming that there will be 2 sockets and 2 cpus totally. However now the actual calculation logic of missing sockets and cores is not immutable and is considered liable to change. Although we will get maxcpus=2 finally based on current parser, it's always stable to specify it explicitly. So "-smp 2,sockets=2,maxcpus=2" will be optimal when we expect multiple sockets and 2 cpus totally. Signed-off-by: Yanan Wang <[email protected]> Reviewed-by: Philippe Mathieu-Daude <[email protected]> Reviewed-by: Daniel P. Berrangé <[email protected]> Reviewed-by: Andrew Jones <[email protected]> Message-Id: <[email protected]> Signed-off-by: Laurent Vivier <[email protected]>
1 parent 553dc36 commit 848dd26

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

qemu-options.hx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ SRST
401401
-m 2G \
402402
-object memory-backend-ram,size=1G,id=m0 \
403403
-object memory-backend-ram,size=1G,id=m1 \
404-
-smp 2 \
404+
-smp 2,sockets=2,maxcpus=2 \
405405
-numa node,nodeid=0,memdev=m0 \
406406
-numa node,nodeid=1,memdev=m1,initiator=0 \
407407
-numa cpu,node-id=0,socket-id=0 \

0 commit comments

Comments
 (0)