scripts: improve message when TAP based tests fail

berrange · bonzini · commit 86f13ef31806 · 2020-07-10T19:26:55.000-04:00
If one of the qtests fails, the TAP driver prints out a message like:

  ERROR - too few tests run (expected 3, got 1)

which fails to tell you which test program failed. This is a critical
ommission when many tests are running in parallel as their output is
interleaved. The improved message is:

  ERROR endianness-test - too few tests run (expected 3, got 1)

Signed-off-by: Daniel P. Berrangé &lt;berrange@redhat.com&gt;
Message-Id: &lt;20200706125054.2619012-1-berrange@redhat.com&gt;
Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
@@ -217,7 +217,7 @@ ($;$)
 
 sub testsuite_error ($)
 {
-  report "ERROR", "- $_[0]";
+  report "ERROR", "$test_name - $_[0]";
 }
 
 sub handle_tap_result ($)

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ ($;$)`
`217`	`217`
`218`	`218`	`sub testsuite_error ($)`
`219`	`219`	`{`
`220`		`- report "ERROR", "- $_[0]";`
	`220`	`+ report "ERROR", "$test_name - $_[0]";`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`sub handle_tap_result ($)`