hw/riscv: shakti_c: Mark as not user creatable

alistair23 · alistair23 · commit 9ae6ecd848dc · 2021-10-07T08:41:33.000+10:00
Mark the shakti_c machine as not user creatable. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639 Signed-off-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <c617a04d4e3dd041a3427b47a1b1d5ab475a2edd.1632871759.git.alistair.francis@wdc.com>
diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c
@@ -150,6 +150,13 @@ static void shakti_c_soc_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     dc->realize = shakti_c_soc_state_realize;
+    /*
+     * Reasons:
+     *     - Creates CPUS in riscv_hart_realize(), and can create unintended
+     *       CPUs
+     *     - Uses serial_hds in realize function, thus can't be used twice
+     */
+    dc->user_creatable = false;
 }
 
 static void shakti_c_soc_instance_init(Object *obj)

Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,13 @@ static void shakti_c_soc_class_init(ObjectClass klass, void data)`
`150`	`150`	`{`
`151`	`151`	`DeviceClass *dc = DEVICE_CLASS(klass);`
`152`	`152`	`dc->realize = shakti_c_soc_state_realize;`
	`153`	`+ /*`
	`154`	`+ * Reasons:`
	`155`	`+ * - Creates CPUS in riscv_hart_realize(), and can create unintended`
	`156`	`+ * CPUs`
	`157`	`+ * - Uses serial_hds in realize function, thus can't be used twice`
	`158`	`+ */`
	`159`	`+ dc->user_creatable = false;`
`153`	`160`	`}`
`154`	`161`
`155`	`162`	`static void shakti_c_soc_instance_init(Object *obj)`