Skip to content

Commit bfe5b84

Browse files
committed
target/s390x: Use cpu_*_mmu instead of helper_*_mmu
The helper_*_mmu functions were the only thing available when this code was written. This could have been adjusted when we added cpu_*_mmuidx_ra, but now we can most easily use the newest set of interfaces. Reviewed-by: David Hildenbrand <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
1 parent 68ad926 commit bfe5b84

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

target/s390x/tcg/mem_helper.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,13 +249,13 @@ static void do_access_memset(CPUS390XState *env, vaddr vaddr, char *haddr,
249249
* page. This is especially relevant to speed up TLB_NOTDIRTY.
250250
*/
251251
g_assert(size > 0);
252-
helper_ret_stb_mmu(env, vaddr, byte, oi, ra);
252+
cpu_stb_mmu(env, vaddr, byte, oi, ra);
253253
haddr = tlb_vaddr_to_host(env, vaddr, MMU_DATA_STORE, mmu_idx);
254254
if (likely(haddr)) {
255255
memset(haddr + 1, byte, size - 1);
256256
} else {
257257
for (i = 1; i < size; i++) {
258-
helper_ret_stb_mmu(env, vaddr + i, byte, oi, ra);
258+
cpu_stb_mmu(env, vaddr + i, byte, oi, ra);
259259
}
260260
}
261261
}
@@ -291,7 +291,7 @@ static uint8_t do_access_get_byte(CPUS390XState *env, vaddr vaddr, char **haddr,
291291
* Do a single access and test if we can then get access to the
292292
* page. This is especially relevant to speed up TLB_NOTDIRTY.
293293
*/
294-
byte = helper_ret_ldub_mmu(env, vaddr + offset, oi, ra);
294+
byte = cpu_ldb_mmu(env, vaddr + offset, oi, ra);
295295
*haddr = tlb_vaddr_to_host(env, vaddr, MMU_DATA_LOAD, mmu_idx);
296296
return byte;
297297
#endif
@@ -325,7 +325,7 @@ static void do_access_set_byte(CPUS390XState *env, vaddr vaddr, char **haddr,
325325
* Do a single access and test if we can then get access to the
326326
* page. This is especially relevant to speed up TLB_NOTDIRTY.
327327
*/
328-
helper_ret_stb_mmu(env, vaddr + offset, byte, oi, ra);
328+
cpu_stb_mmu(env, vaddr + offset, byte, oi, ra);
329329
*haddr = tlb_vaddr_to_host(env, vaddr, MMU_DATA_STORE, mmu_idx);
330330
#endif
331331
}

0 commit comments

Comments
 (0)