ibex_uart: fix XOR-as-pow

bonzini · bonzini · commit c8d7fd059d73 · 2020-06-26T09:39:40.000-04:00
The xor-as-pow warning in clang actually detected a genuine bug.
Fix it.

Signed-off-by: Paolo Bonzini &lt;pbonzini@redhat.com&gt;
diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c
@@ -331,7 +331,7 @@ static void ibex_uart_write(void *opaque, hwaddr addr,
         if (value & UART_CTRL_NCO) {
             uint64_t baud = ((value & UART_CTRL_NCO) >> 16);
             baud *= 1000;
-            baud /= 2 ^ 20;
+            baud >>= 20;
 
             s->char_tx_time = (NANOSECONDS_PER_SECOND / baud) * 10;
         }

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ static void ibex_uart_write(void *opaque, hwaddr addr,`
`331`	`331`	`if (value & UART_CTRL_NCO) {`
`332`	`332`	`uint64_t baud = ((value & UART_CTRL_NCO) >> 16);`
`333`	`333`	`baud *= 1000;`
`334`		`- baud /= 2 ^ 20;`
	`334`	`+ baud >>= 20;`
`335`	`335`
`336`	`336`	`s->char_tx_time = (NANOSECONDS_PER_SECOND / baud) * 10;`
`337`	`337`	`}`