Skip to content

Commit d0a7920

Browse files
pm215vivier
authored andcommitted
linux-user: Drop unneeded includes from qemu.h
Trim down the #includes in qemu.h where we can, either by dropping unneeded headers or by moving them to user-internals.h. This includes deleting a couple of #includes that appear at weird points midway through the header file. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-Id: <[email protected]> Signed-off-by: Laurent Vivier <[email protected]>
1 parent 85b4fa0 commit d0a7920

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

linux-user/qemu.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#define QEMU_H
33

44
#include "cpu.h"
5-
#include "exec/exec-all.h"
65
#include "exec/cpu_ldst.h"
76

87
#undef DEBUG_REMAP
@@ -163,8 +162,6 @@ typedef struct TaskState {
163162
struct target_sigaltstack sigaltstack_used;
164163
} __attribute__((aligned(16))) TaskState;
165164

166-
#include "qemu/log.h"
167-
168165
abi_long do_brk(abi_ulong new_brk);
169166

170167
/* user access */
@@ -349,5 +346,4 @@ void *lock_user_string(abi_ulong guest_addr);
349346
#define unlock_user_struct(host_ptr, guest_addr, copy) \
350347
unlock_user(host_ptr, guest_addr, (copy) ? sizeof(*host_ptr) : 0)
351348

352-
#include <pthread.h>
353349
#endif /* QEMU_H */

linux-user/user-internals.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020

2121
#include "hostdep.h"
2222
#include "exec/user/thunk.h"
23+
#include "exec/exec-all.h"
24+
#include "qemu/log.h"
2325

2426
extern char *exec_path;
2527
void init_task_state(TaskState *ts);

thunk.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
1818
*/
1919
#include "qemu/osdep.h"
20+
#include "qemu/log.h"
2021

2122
#include "qemu.h"
2223
#include "exec/user/thunk.h"

0 commit comments

Comments
 (0)