Skip to content

Commit de82640

Browse files
gnifkraxel
authored andcommitted
audio/jack: do not remove ports when finishing
This fixes a hang when there is a communications issue with the JACK server. Simply closing the connection is enough to completely clean up and as such we do not need to remove the ports first. As JACK uses a socket based protocol that relies on the `select` call, if there is a communication breakdown with the server the client library waits forever for a response to the unregister request. Signed-off-by: Geoffrey McRae <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
1 parent f8f0f21 commit de82640

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

audio/jackaudio.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -548,9 +548,6 @@ static void qjack_client_fini(QJackClient *c)
548548
{
549549
switch (c->state) {
550550
case QJACK_STATE_RUNNING:
551-
for (int i = 0; i < c->nchannels; ++i) {
552-
jack_port_unregister(c->client, c->port[i]);
553-
}
554551
jack_deactivate(c->client);
555552
/* fallthrough */
556553

0 commit comments

Comments
 (0)