Skip to content

Commit efee71c

Browse files
rth7680vivier
authored andcommitted
tests/tcg/multiarch: Re-enable signals test for most guests
With signal trampolines safely off the stack for all guests besides hppa, we can re-enable this test. It does show up a problem with sh4 (unrelated?), so leave that test disabled for now. Signed-off-by: Richard Henderson <[email protected]> Message-Id: <[email protected]> Signed-off-by: Laurent Vivier <[email protected]>
1 parent 525c467 commit efee71c

File tree

4 files changed

+14
-11
lines changed

4 files changed

+14
-11
lines changed

tests/tcg/hppa/Makefile.target

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,10 @@
55
# On parisc Linux supports 4K/16K/64K (but currently only 4k works)
66
EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
77

8+
# This triggers failures for hppa-linux about 1% of the time
9+
# HPPA is the odd target that can't use the sigtramp page;
10+
# it requires the full vdso with dwarf2 unwind info.
11+
run-signals: signals
12+
$(call skip-test, $<, "BROKEN awaiting vdso support")
13+
run-plugin-signals-with-%:
14+
$(call skip-test, $<, "BROKEN awaiting vdso support")

tests/tcg/i386/Makefile.target

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ run-plugin-%-with-libinsn.so:
6565
-d plugin -D $*-with-libinsn.so.pout $*, \
6666
"$* (inline) on $(TARGET_NAME)")
6767

68-
run-plugin-signals-with-libinsn.so:
69-
$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups and vdso support")
70-
7168
# Update TESTS
7269
I386_TESTS:=$(filter-out $(SKIP_I386_TESTS), $(ALL_X86_TESTS))
7370
TESTS=$(MULTIARCH_TESTS) $(I386_TESTS)

tests/tcg/multiarch/Makefile.target

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,6 @@ threadcount: LDFLAGS+=-lpthread
3232

3333
signals: LDFLAGS+=-lrt -lpthread
3434

35-
# This triggers failures on s390x hosts about 4% of the time
36-
# This triggers failures for hppa-linux about 1% of the time
37-
run-signals: signals
38-
$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups and vdso support")
39-
40-
run-plugin-signals-with-%:
41-
$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups and vdso support")
42-
4335
# We define the runner for test-mmap after the individual
4436
# architectures have defined their supported pages sizes. If no
4537
# additional page sizes are defined we only run the default test.

tests/tcg/sh4/Makefile.target

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,10 @@
55

66
# On sh Linux supports 4k, 8k, 16k and 64k pages (but only 4k currently works)
77
EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-8192 run-test-mmap-16384 run-test-mmap-65536
8+
9+
# This triggers failures for sh4-linux about 10% of the time.
10+
# Random SIGSEGV at unpredictable guest address, cause unknown.
11+
run-signals: signals
12+
$(call skip-test, $<, "BROKEN")
13+
run-plugin-signals-with-%:
14+
$(call skip-test, $<, "BROKEN")

0 commit comments

Comments
 (0)