Skip to content

Commit fa6c953

Browse files
committed
adb: use adb_device prefix for ADB device trace events
This is to allow us to distinguish between ADB device events and ADB bus events separately. Signed-off-by: Mark Cave-Ayland <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Tested-by: Finn Thain <[email protected]> Acked-by: Laurent Vivier <[email protected]> Message-Id: <[email protected]>
1 parent 913f47e commit fa6c953

File tree

3 files changed

+22
-22
lines changed

3 files changed

+22
-22
lines changed

hw/input/adb-kbd.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ static int adb_kbd_request(ADBDevice *d, uint8_t *obuf,
243243
olen = 0;
244244
switch (cmd) {
245245
case ADB_WRITEREG:
246-
trace_adb_kbd_writereg(reg, buf[1]);
246+
trace_adb_device_kbd_writereg(reg, buf[1]);
247247
switch (reg) {
248248
case 2:
249249
/* LED status */
@@ -256,7 +256,7 @@ static int adb_kbd_request(ADBDevice *d, uint8_t *obuf,
256256
case ADB_CMD_CHANGE_ID_AND_ACT:
257257
case ADB_CMD_CHANGE_ID_AND_ENABLE:
258258
d->devaddr = buf[1] & 0xf;
259-
trace_adb_kbd_request_change_addr(d->devaddr);
259+
trace_adb_device_kbd_request_change_addr(d->devaddr);
260260
break;
261261
default:
262262
d->devaddr = buf[1] & 0xf;
@@ -270,8 +270,8 @@ static int adb_kbd_request(ADBDevice *d, uint8_t *obuf,
270270
d->handler = buf[2];
271271
}
272272

273-
trace_adb_kbd_request_change_addr_and_handler(d->devaddr,
274-
d->handler);
273+
trace_adb_device_kbd_request_change_addr_and_handler(
274+
d->devaddr, d->handler);
275275
break;
276276
}
277277
}
@@ -294,7 +294,7 @@ static int adb_kbd_request(ADBDevice *d, uint8_t *obuf,
294294
olen = 2;
295295
break;
296296
}
297-
trace_adb_kbd_readreg(reg, obuf[0], obuf[1]);
297+
trace_adb_device_kbd_readreg(reg, obuf[0], obuf[1]);
298298
break;
299299
}
300300
return olen;
@@ -321,7 +321,7 @@ static void adb_keyboard_event(DeviceState *dev, QemuConsole *src,
321321
/* FIXME: take handler into account when translating qcode */
322322
keycode = qcode_to_adb_keycode[qcode];
323323
if (keycode == NO_KEY) { /* We don't want to send this to the guest */
324-
trace_adb_kbd_no_key();
324+
trace_adb_device_kbd_no_key();
325325
return;
326326
}
327327
if (evt->u.key.data->down == false) { /* if key release event */

hw/input/adb-mouse.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ static int adb_mouse_request(ADBDevice *d, uint8_t *obuf,
121121
s->dx = 0;
122122
s->dy = 0;
123123
s->dz = 0;
124-
trace_adb_mouse_flush();
124+
trace_adb_device_mouse_flush();
125125
return 0;
126126
}
127127

@@ -130,7 +130,7 @@ static int adb_mouse_request(ADBDevice *d, uint8_t *obuf,
130130
olen = 0;
131131
switch (cmd) {
132132
case ADB_WRITEREG:
133-
trace_adb_mouse_writereg(reg, buf[1]);
133+
trace_adb_device_mouse_writereg(reg, buf[1]);
134134
switch (reg) {
135135
case 2:
136136
break;
@@ -152,7 +152,7 @@ static int adb_mouse_request(ADBDevice *d, uint8_t *obuf,
152152
case ADB_CMD_CHANGE_ID_AND_ACT:
153153
case ADB_CMD_CHANGE_ID_AND_ENABLE:
154154
d->devaddr = buf[1] & 0xf;
155-
trace_adb_mouse_request_change_addr(d->devaddr);
155+
trace_adb_device_mouse_request_change_addr(d->devaddr);
156156
break;
157157
default:
158158
d->devaddr = buf[1] & 0xf;
@@ -172,8 +172,8 @@ static int adb_mouse_request(ADBDevice *d, uint8_t *obuf,
172172
d->handler = buf[2];
173173
}
174174

175-
trace_adb_mouse_request_change_addr_and_handler(d->devaddr,
176-
d->handler);
175+
trace_adb_device_mouse_request_change_addr_and_handler(
176+
d->devaddr, d->handler);
177177
break;
178178
}
179179
}
@@ -191,7 +191,7 @@ static int adb_mouse_request(ADBDevice *d, uint8_t *obuf,
191191
olen = 2;
192192
break;
193193
}
194-
trace_adb_mouse_readreg(reg, obuf[0], obuf[1]);
194+
trace_adb_device_mouse_readreg(reg, obuf[0], obuf[1]);
195195
break;
196196
}
197197
return olen;

hw/input/trace-events

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
# See docs/devel/tracing.txt for syntax documentation.
22

33
# adb-kbd.c
4-
adb_kbd_no_key(void) "Ignoring NO_KEY"
5-
adb_kbd_writereg(int reg, uint8_t val) "reg %d val 0x%2.2x"
6-
adb_kbd_readreg(int reg, uint8_t val0, uint8_t val1) "reg %d obuf[0] 0x%2.2x obuf[1] 0x%2.2x"
7-
adb_kbd_request_change_addr(int devaddr) "change addr to 0x%x"
8-
adb_kbd_request_change_addr_and_handler(int devaddr, int handler) "change addr and handler to 0x%x, 0x%x"
4+
adb_device_kbd_no_key(void) "Ignoring NO_KEY"
5+
adb_device_kbd_writereg(int reg, uint8_t val) "reg %d val 0x%2.2x"
6+
adb_device_kbd_readreg(int reg, uint8_t val0, uint8_t val1) "reg %d obuf[0] 0x%2.2x obuf[1] 0x%2.2x"
7+
adb_device_kbd_request_change_addr(int devaddr) "change addr to 0x%x"
8+
adb_device_kbd_request_change_addr_and_handler(int devaddr, int handler) "change addr and handler to 0x%x, 0x%x"
99

1010
# adb-mouse.c
11-
adb_mouse_flush(void) "flush"
12-
adb_mouse_writereg(int reg, uint8_t val) "reg %d val 0x%2.2x"
13-
adb_mouse_readreg(int reg, uint8_t val0, uint8_t val1) "reg %d obuf[0] 0x%2.2x obuf[1] 0x%2.2x"
14-
adb_mouse_request_change_addr(int devaddr) "change addr to 0x%x"
15-
adb_mouse_request_change_addr_and_handler(int devaddr, int handler) "change addr and handler to 0x%x, 0x%x"
11+
adb_device_mouse_flush(void) "flush"
12+
adb_device_mouse_writereg(int reg, uint8_t val) "reg %d val 0x%2.2x"
13+
adb_device_mouse_readreg(int reg, uint8_t val0, uint8_t val1) "reg %d obuf[0] 0x%2.2x obuf[1] 0x%2.2x"
14+
adb_device_mouse_request_change_addr(int devaddr) "change addr to 0x%x"
15+
adb_device_mouse_request_change_addr_and_handler(int devaddr, int handler) "change addr and handler to 0x%x, 0x%x"
1616

1717
# pckbd.c
1818
pckbd_kbd_read_data(uint32_t val) "0x%02x"

0 commit comments

Comments
 (0)