Skip to content

remove scrollbar styles on screenshot #8040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Light2Dark wants to merge 9 commits into from
Closed

remove scrollbar styles on screenshot #8040

Light2Dark wants to merge 9 commits into from

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Jan 29, 2026 •
edited
Loading

📝 Summary

  • Patches html-to-image with extra-style-content.
  • For auto-export, we don't expand the cell's height
  • Remove scrollbars

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@Light2Dark Light2Dark requested a review from manzt as a code owner January 29, 2026 02:52
@vercel
Copy link

vercel bot commented Jan 29, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jan 29, 2026 9:47am

Request Review

@Light2Dark Light2Dark added the enhancement New feature or request label Jan 29, 2026
mscolnick
mscolnick reviewed Jan 29, 2026
View reviewed changes
frontend/src/utils/download.ts
*/
function prepareCellElementForScreenshot(element: HTMLElement) {
const originalOverflow = element.style.overflow;
const maxHeight = element.style.maxHeight;
Copy link
Contributor

@mscolnick mscolnick Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try cloneNode()

That might help avoid messing up the view on auto-export

@Light2Dark Light2Dark requested a review from akshayka as a code owner January 29, 2026 09:45
@mscolnick
Copy link
Contributor

mscolnick commented Jan 29, 2026

I think snappy is confusing and incorrect. The background snapshots will cache images that are not optimal when intentionally downloading. We should aim to remove it, but if not, I'd rename it to backgroundDownload

@Light2Dark
Copy link
Contributor Author

Light2Dark commented Jan 29, 2026

I think snappy is confusing and incorrect. The background snapshots will cache images that are not optimal when intentionally downloading. We should aim to remove it, but if not, I'd rename it to backgroundDownload

Maybe this isn't the behaviour you are talking about, but if you turned on auto-export, and then Download to PDF, it wouldn't re-take the screenshots. That's because we didn't detect that the value changed to retake screenshots.

@Light2Dark Light2Dark marked this pull request as draft January 29, 2026 15:40
@Light2Dark Light2Dark closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick left review comments

@manzt manzt Awaiting requested review from manzt manzt is a code owner

@akshayka akshayka Awaiting requested review from akshayka akshayka is a code owner

Assignees

No one assigned

Labels

dependencies enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick