Skip to content

Commit 0c9cd08

Browse files
committed
Remove redundant nextTick
1 parent 391560c commit 0c9cd08

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

tests/unit/components/AdjustableSidebarWidth.spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,6 @@ describe('AdjustableSidebarWidth', () => {
621621
}],
622622
}));
623623
await wrapper.vm.$nextTick();
624-
await flushPromises();
625624
expect(store.state.contentWidth).toBe(99);
626625
});
627626

tests/unit/components/Filter/FilterInput.spec.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ describe('FilterInput', () => {
107107
it('renders focus class if showSuggestedTags is true and border style is not prevented', async () => {
108108
await wrapper.setData({ showSuggestedTags: true });
109109
await wrapper.setProps({ preventBorderStyle: false });
110-
await wrapper.vm.$nextTick();
111110

112111
expect(wrapper.findComponent('.filter.focus').exists()).toBe(true);
113112
});
@@ -143,7 +142,6 @@ describe('FilterInput', () => {
143142

144143
it('renders an filter label element that has a input-value attrib to resize the input', async () => {
145144
await wrapper.setProps({ value: inputValue });
146-
await wrapper.vm.$nextTick();
147145
const filterLabel = wrapper.findComponent('#filter-label');
148146
// check input-value attrib for filter label contains the input value
149147
expect(filterLabel.attributes('data-value')).toBe(inputValue);
@@ -158,7 +156,6 @@ describe('FilterInput', () => {
158156

159157
// simulate the `handleScrollbar` mixin triggering ON
160158
await wrapper.setData({ isScrolling: true });
161-
await wrapper.vm.$nextTick();
162159

163160
expect(inputBoxWrapper.classes('scrolling')).toBe(true);
164161
});
@@ -708,7 +705,6 @@ describe('FilterInput', () => {
708705
await wrapper.vm.$nextTick();
709706

710707
await wrapper.setProps({ selectedTags: [selectedTag] });
711-
await wrapper.vm.$nextTick();
712708
selectedTagsComponent = wrapper.findComponent({ ref: 'selectedTags' });
713709
});
714710

@@ -748,7 +744,6 @@ describe('FilterInput', () => {
748744
document.activeElement.blur();
749745
await wrapper.vm.$nextTick();
750746
await wrapper.setProps({ selectedTags: [] });
751-
await wrapper.vm.$nextTick();
752747
expect(document.activeElement).not.toEqual(input.element);
753748
});
754749

@@ -903,7 +898,6 @@ describe('FilterInput', () => {
903898
it('deletes selected tag when tag is clicked on a virtual keyboard', async () => {
904899
await wrapper.setData({ keyboardIsVirtual: true });
905900
await wrapper.setProps({ selectedTags: [selectedTag, 'Tag2'] });
906-
await wrapper.vm.$nextTick();
907901

908902
selectedTagsComponent.vm.$emit('click-tags', { tagName: 'Tag2' });
909903
await flushPromises();
@@ -932,7 +926,6 @@ describe('FilterInput', () => {
932926

933927
it('resets filters when `deleteButton` is clicked', async () => {
934928
await wrapper.setProps({ value: '', selectedTags: [] });
935-
await wrapper.vm.$nextTick();
936929
const deleteBtn = wrapper.findComponent('.filter__delete-button');
937930
await deleteBtn.trigger('click');
938931

@@ -1127,7 +1120,6 @@ describe('FilterInput', () => {
11271120

11281121
it('assigns selected tags to active tags when cmd + a is triggered on input', async () => {
11291122
await wrapper.setProps({ value: 'Foo', selectedTags: tags });
1130-
await wrapper.vm.$nextTick();
11311123
const selectedTagsComponent = wrapper.findComponent({ ref: 'selectedTags' });
11321124
wrapper.findComponent('input').trigger('keydown', {
11331125
key: 'a',
@@ -1403,7 +1395,6 @@ describe('FilterInput', () => {
14031395
beforeEach(async () => {
14041396
jest.resetAllMocks();
14051397
await wrapper.setProps({ selectedTags });
1406-
await wrapper.vm.$nextTick();
14071398
selectedTagsComponent = wrapper.findComponent({ ref: 'selectedTags' });
14081399
spyFocusTag = jest.spyOn(selectedTagsComponent.vm, 'focusTag').mockReturnValueOnce();
14091400
});

0 commit comments

Comments
 (0)