[ML] Fix ModelRegistryMetadataTests (elastic#125756) (elastic#125861)

davidkyle · web-flow · commit 6c851eff3bb9 · 2025-03-29T03:16:36.000+11:00
(cherry picked from commit 67798dd) # Conflicts: # muted-tests.yml
diff --git a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/registry/ModelRegistryMetadataTests.java b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/registry/ModelRegistryMetadataTests.java
@@ -30,7 +30,7 @@ public static ModelRegistryMetadata randomInstance() {
     }
 
     public static ModelRegistryMetadata randomInstance(boolean isUpgraded) {
-        if (rarely()) {
+        if (rarely() && isUpgraded == false) {
             return ModelRegistryMetadata.EMPTY;
         }
         int size = randomIntBetween(1, 5);

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public static ModelRegistryMetadata randomInstance() {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`public static ModelRegistryMetadata randomInstance(boolean isUpgraded) {`
`33`		`- if (rarely()) {`
	`33`	`+ if (rarely() && isUpgraded == false) {`
`34`	`34`	`return ModelRegistryMetadata.EMPTY;`
`35`	`35`	`}`
`36`	`36`	`int size = randomIntBetween(1, 5);`