Suppress failing rules

timotheeguerin · timotheeguerin · commit 276d658db232 · 2024-06-04T07:57:57.000-07:00
diff --git a/specification/ai/HealthInsights/HealthInsights.Common/model.common.fhir.resources.tsp b/specification/ai/HealthInsights/HealthInsights.Common/model.common.fhir.resources.tsp
@@ -28,6 +28,7 @@ model Resource is Record<unknown> {
 
 #suppress "@azure-tools/typespec-azure-core/bad-record-type" "model should have additionalProperties"
 #suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "must extends Resource to be able use clientName in both Resource and DomainResource"
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("""
 A resource with narrative, extensions, and contained resources
 Based on [FHIR DomainResource](https://www.hl7.org/fhir/domainresource.html)
diff --git a/specification/ai/HealthInsights/HealthInsights.RadiologyInsights/model.radiologyinsights.tsp b/specification/ai/HealthInsights/HealthInsights.RadiologyInsights/model.radiologyinsights.tsp
@@ -93,6 +93,7 @@ model RadiologyInsightsPatientResult {
   inferences: RadiologyInsightsInference[];
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("""
 An inference made by the Radiology Insights model regarding a patient.
   - AgeMismatch
@@ -246,6 +247,7 @@ model FollowupRecommendationInference extends RadiologyInsightsInference {
   recommendedProcedure: ProcedureRecommendation;
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("The procedure recommendation can be a generic procedure or an imaging procedure.")
 @discriminator("kind")
 model ProcedureRecommendation {
diff --git a/specification/ai/OpenAI.Assistants/messages/models.tsp b/specification/ai/OpenAI.Assistants/messages/models.tsp
@@ -120,6 +120,7 @@ union MessageAttachmentToolDefinition {
 @doc("An abstract representation of a single item of thread message content.")
 @added(ServiceApiVersions.v2024_02_15_preview)
 model MessageContent {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
@@ -163,6 +164,7 @@ model MessageTextDetails {
 @doc("An abstract representation of an annotation to text thread message content.")
 @added(ServiceApiVersions.v2024_02_15_preview)
 model MessageTextAnnotation {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 
@@ -322,6 +324,7 @@ model MessageDeltaContent {
   index: int32;
 
   /** The type of content for this content part. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   type: string;
 }
 
@@ -372,6 +375,7 @@ model MessageDeltaTextAnnotation {
   index: int32;
 
   /** The type of the text content annotation. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   type: string;
 }
 
diff --git a/specification/ai/OpenAI.Assistants/run_steps/models.tsp b/specification/ai/OpenAI.Assistants/run_steps/models.tsp
@@ -219,6 +219,7 @@ model RunStepDelta {
 @added(ServiceApiVersions.v2024_02_15_preview)
 model RunStepDeltaDetail {
   /** The object type for the run step detail object. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   type: string;
 }
 
@@ -263,6 +264,7 @@ model RunStepDeltaToolCall {
   id: string;
 
   /** The type of the tool call detail item in a streaming run step's details. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   type: string;
 }
 
@@ -334,6 +336,7 @@ model RunStepDeltaCodeInterpreterOutput {
   index: int32;
 
   /** The type of the streaming run step tool call's Code Interpreter output. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   type: string;
 }
 
diff --git a/specification/ai/OpenAI.Assistants/runs/models.tsp b/specification/ai/OpenAI.Assistants/runs/models.tsp
@@ -328,6 +328,7 @@ union RunStatus {
 @doc("An abstract representation of a required action for an assistant thread run to continue.")
 @added(ServiceApiVersions.v2024_02_15_preview)
 model RequiredAction {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
diff --git a/specification/ai/OpenAI.Assistants/tools/models.tsp b/specification/ai/OpenAI.Assistants/tools/models.tsp
@@ -14,6 +14,7 @@ namespace Azure.AI.OpenAI.Assistants;
 @discriminator("type")
 @added(ServiceApiVersions.v2024_02_15_preview)
 model ToolDefinition {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
@@ -68,6 +69,7 @@ An abstract representation a a tool invocation needed by the model to continue a
 """)
 @added(ServiceApiVersions.v2024_02_15_preview)
 model RequiredToolCall {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type for the required tool call.")
   type: string;
 
@@ -103,6 +105,7 @@ model RequiredFunctionToolCallDetails {
 @doc("An abstract representation of a detailed tool call as recorded within a run step for an existing run.")
 @added(ServiceApiVersions.v2024_02_15_preview)
 model RunStepToolCall {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 
@@ -167,6 +170,7 @@ model RunStepCodeInterpreterToolCallDetails {
 @doc("An abstract representation of an emitted output from a code interpreter tool.")
 @added(ServiceApiVersions.v2024_02_15_preview)
 model RunStepCodeInterpreterToolCallOutput {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
diff --git a/specification/cognitiveservices/OpenAI.Inference/models/completions/chat_completions.tsp b/specification/cognitiveservices/OpenAI.Inference/models/completions/chat_completions.tsp
@@ -24,6 +24,7 @@ mode.
 """)
 @discriminator("type")
 model ChatCompletionsResponseFormat {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The discriminated type for the response format.")
   type: string;
 }
@@ -333,6 +334,7 @@ model ChatCompletions {
 @discriminator("type")
 @doc("An abstract representation of structured information about why a chat completions response terminated.")
 model ChatFinishDetails {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
diff --git a/specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp b/specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp
@@ -20,6 +20,7 @@ alias ChatMessageContent = string | ChatMessageContentItem[];
 @doc("An abstract representation of a structured content item within a chat message.")
 @discriminator("type")
 model ChatMessageContentItem {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The discriminated object type.")
   type: string;
 }
diff --git a/specification/cognitiveservices/OpenAI.Inference/models/completions/tools.tsp b/specification/cognitiveservices/OpenAI.Inference/models/completions/tools.tsp
@@ -31,6 +31,7 @@ union ChatCompletionsToolSelectionPreset {
 @discriminator("type")
 @doc("An abstract representation of an explicit, named tool selection to use for a chat completions request.")
 model ChatCompletionsNamedToolSelection {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
@@ -59,6 +60,7 @@ model ChatCompletionsFunctionToolSelection {
 @doc("An abstract representation of a tool that can be used by the model to improve a chat completions response.")
 @added(ServiceApiVersions.v2024_02_15_Preview)
 model ChatCompletionsToolDefinition {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 }
@@ -85,6 +87,7 @@ chat completion.
 """)
 @added(ServiceApiVersions.v2024_02_15_Preview)
 model ChatCompletionsToolCall {
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @doc("The object type.")
   type: string;
 
diff --git a/specification/confidentialledger/Microsoft.ManagedCcf/service_state.tsp b/specification/confidentialledger/Microsoft.ManagedCcf/service_state.tsp
@@ -58,6 +58,7 @@ union NodeStatus {
   "Retired",
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("Common type for attestation information, describing the cryptographically-endorsed claim of what code is executing, and what platform it is executing on. Derived types contain platform-specific details.")
 @discriminator("format")
 model QuoteInfo {}
diff --git a/specification/databasewatcher/DatabaseWatcher.Management/baseTarget.tsp b/specification/databasewatcher/DatabaseWatcher.Management/baseTarget.tsp
@@ -28,6 +28,7 @@ model Target is ProxyResource<TargetProperties> {
   name: string;
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("The generic properties of a target.")
 @discriminator("targetType")
 model TargetProperties {
diff --git a/specification/devopsinfrastructure/Microsoft.DevOpsInfrastructure/main.tsp b/specification/devopsinfrastructure/Microsoft.DevOpsInfrastructure/main.tsp
@@ -61,6 +61,7 @@ model PoolProperties {
   devCenterProjectResourceId: string;
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("Defines the organization in which the pool will be used.")
 @discriminator("kind")
 model OrganizationProfile {}
@@ -131,6 +132,7 @@ union AzureDevOpsPermissionType {
   "SpecificAccounts",
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("Defines the type of fabric the agent will run on.")
 @discriminator("kind")
 model FabricProfile {}
@@ -286,6 +288,7 @@ model NetworkProfile {
   subnetId: string;
 }
 
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @doc("The agent profile of the machines in the pool.")
 @discriminator("kind")
 model AgentProfile {
diff --git a/specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.Media/MediaServices.tsp b/specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.Media/MediaServices.tsp
@@ -141,6 +141,7 @@ namespace Microsoft.EventGrid.SystemEvents {
   @discriminator("@odata.type")
   model MediaJobOutput {
     /** The discriminator for derived types. */
+    #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
     #suppress "@azure-tools/typespec-azure-core/casing-style" "Maintain compatibility with existing models."
     `@odata.type`: string;
 
diff --git a/specification/portalservices/Extension.Management/models.tsp b/specification/portalservices/Extension.Management/models.tsp
@@ -428,6 +428,7 @@ model PortalExtensionListSourcesFolder {
 /**
  * The content metadata of a file
  */
+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
 @discriminator("kind")
 model PortalExtensionListSourcesFile {
   /**
diff --git a/specification/riskiq/Easm/models.tsp b/specification/riskiq/Easm/models.tsp
@@ -220,6 +220,7 @@ model AssetPageResult {
 @resource("assets")
 model AssetResource {
   /** Discriminator property for AssetResource. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   kind: string;
 
   @doc("The system generated unique id for the resource.")
@@ -483,6 +484,7 @@ model DataConnectionProperties {}
 @clientName("DataConnectionPayload", "csharp")
 model DataConnectionData {
   /** Discriminator property for DataConnectionData. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   kind: string;
 
   @doc("The name of data connection")
@@ -503,6 +505,7 @@ model DataConnectionData {
 @resource("dataConnections")
 model DataConnection {
   /** Discriminator property for DataConnection. */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   kind: string;
 
   @doc("The system generated unique id for the resource.")
diff --git a/specification/workloads/Workloads.SAPMonitor.Management/models.tsp b/specification/workloads/Workloads.SAPMonitor.Management/models.tsp
@@ -272,6 +272,7 @@ model ProviderSpecificProperties {
   /**
    * The provider type. For example, the value can be SapHana.
    */
+  #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"
   @visibility("read", "create")
   providerType: string;
 }

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ model RadiologyInsightsPatientResult {`
`93`	`93`	`inferences: RadiologyInsightsInference[];`
`94`	`94`	`}`
`95`	`95`
	`96`	`+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`96`	`97`	`@doc("""`
`97`	`98`	`An inference made by the Radiology Insights model regarding a patient.`
`98`	`99`	`- AgeMismatch`
`@@ -246,6 +247,7 @@ model FollowupRecommendationInference extends RadiologyInsightsInference {`
`246`	`247`	`recommendedProcedure: ProcedureRecommendation;`
`247`	`248`	`}`
`248`	`249`
	`250`	`+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`249`	`251`	`@doc("The procedure recommendation can be a generic procedure or an imaging procedure.")`
`250`	`252`	`@discriminator("kind")`
`251`	`253`	`model ProcedureRecommendation {`
Original file line number	Diff line number	Diff line change
`@@ -219,6 +219,7 @@ model RunStepDelta {`
`219`	`219`	`@added(ServiceApiVersions.v2024_02_15_preview)`
`220`	`220`	`model RunStepDeltaDetail {`
`221`	`221`	`/** The object type for the run step detail object. */`
	`222`	`+ #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`222`	`223`	`type: string;`
`223`	`224`	`}`
`224`	`225`
`@@ -263,6 +264,7 @@ model RunStepDeltaToolCall {`
`263`	`264`	`id: string;`
`264`	`265`
`265`	`266`	`/** The type of the tool call detail item in a streaming run step's details. */`
	`267`	`+ #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`266`	`268`	`type: string;`
`267`	`269`	`}`
`268`	`270`
`@@ -334,6 +336,7 @@ model RunStepDeltaCodeInterpreterOutput {`
`334`	`336`	`index: int32;`
`335`	`337`
`336`	`338`	`/** The type of the streaming run step tool call's Code Interpreter output. */`
	`339`	`+ #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`337`	`340`	`type: string;`
`338`	`341`	`}`
`339`	`342`
Original file line number	Diff line number	Diff line change
`@@ -328,6 +328,7 @@ union RunStatus {`
`328`	`328`	`@doc("An abstract representation of a required action for an assistant thread run to continue.")`
`329`	`329`	`@added(ServiceApiVersions.v2024_02_15_preview)`
`330`	`330`	`model RequiredAction {`
	`331`	`+ #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`331`	`332`	`@doc("The object type.")`
`332`	`333`	`type: string;`
`333`	`334`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ alias ChatMessageContent = string \| ChatMessageContentItem[];`
`20`	`20`	`@doc("An abstract representation of a structured content item within a chat message.")`
`21`	`21`	`@discriminator("type")`
`22`	`22`	`model ChatMessageContentItem {`
	`23`	`+ #suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`23`	`24`	`@doc("The discriminated object type.")`
`24`	`25`	`type: string;`
`25`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ union NodeStatus {`
`58`	`58`	`"Retired",`
`59`	`59`	`}`
`60`	`60`
	`61`	`+#suppress "@azure-tools/typespec-azure-core/no-string-discriminator" "Existing"`
`61`	`62`	`@doc("Common type for attestation information, describing the cryptographically-endorsed claim of what code is executing, and what platform it is executing on. Derived types contain platform-specific details.")`
`62`	`63`	`@discriminator("format")`
`63`	`64`	`model QuoteInfo {}`