rewrite runtime-compile

Author: markhuang1212

backend/cmd/compile_user_code.go

@@ -13,12 +13,17 @@ import (
 	"github.com/pkg/errors"
 )
 
-const CompilationMemoryLimit = 50 * 1024 * 1024
+// Memory Limit of a G++ Process
+const CompilationMemoryLimit = 100 * 1024 * 1024
+
+// it is required that the docker image is built before the program runs
 const imageName = "markhuang1212/code-grader/runtime-compile"
 
 var InternalError = errors.New("internal error")
 var CompilationFailure = errors.New("compilation error")
 
+// The function compiles user's code inside a docker container, and returns the
+// executable on success
 func CompileUserCode(ctx context.Context, gr types.GradeRequest) ([]byte, error) {
 
 	cli, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation())
@@ -33,52 +38,59 @@ func CompileUserCode(ctx context.Context, gr types.GradeRequest) ([]byte, error)
 		},
 		AttachStdin:  true,
 		AttachStdout: true,
+		AttachStderr: true,
+		OpenStdin:    true,
 	}, &container.HostConfig{
 		NetworkMode: "none",
-		Resources: container.Resources{
-			Memory: CompilationMemoryLimit,
+		Resources:   container.Resources{
+			// Memory: CompilationMemoryLimit,
 		},
 	}, nil, nil, "")
 
 	if err != nil {
-		return nil, errors.Wrap(err, "cannot create container")
+		return nil, errors.Wrap(InternalError, "cannot create container")
 	}
 
-	cli.ContainerStart(ctx, resp.ID, dockertypes.ContainerStartOptions{})
-
 	hjresp, err := cli.ContainerAttach(ctx, resp.ID, dockertypes.ContainerAttachOptions{
+		Stream: true,
 		Stdin:  true,
 		Stdout: true,
 		Stderr: true,
 	})
 
 	if err != nil {
-		return nil, errors.Wrap(err, "cannot attach container")
+		return nil, errors.Wrap(InternalError, "cannot attach container")
+	}
+
+	statucCh, errCh := cli.ContainerWait(ctx, resp.ID, container.WaitConditionNextExit)
+
+	err = cli.ContainerStart(ctx, resp.ID, dockertypes.ContainerStartOptions{})
+	if err != nil {
+		return nil, errors.Wrap(InternalError, "cannot start container")
 	}
 
 	outR, outW := io.Pipe()
 	errR, errW := io.Pipe()
-
-	stdcopy.StdCopy(outW, errW, hjresp.Reader)
 	hjresp.Conn.Write([]byte(gr.UserCode))
+	hjresp.Conn.Close()
+	stdcopy.StdCopy(outW, errW, hjresp.Conn)
 
-	statucCh, errCh := cli.ContainerWait(ctx, resp.ID, container.WaitConditionNextExit)
 	select {
 	case status := <-statucCh:
 		if status.StatusCode == 0 {
 			out, err := io.ReadAll(outR)
 			if err != nil {
-				return nil, errors.Wrap(err, "cannot read stdout")
+				return nil, errors.Wrap(InternalError, "cannot read stdout")
 			}
 			return out, err
 		} else {
 			out, err := io.ReadAll(errR)
 			if err != nil {
-				return nil, errors.Wrap(err, "cannot read stderr")
+				return nil, errors.Wrap(InternalError, "cannot read stderr")
 			}
-			return out, errors.New("compilation failed")
+			return out, CompilationFailure
 		}
-	case err := <-errCh:
-		return nil, err
+	case <-errCh:
+		return nil, errors.Wrap(InternalError, "error waiting container")
 	}
 }

backend/cmd/compile_user_code_test.go

@@ -0,0 +1,21 @@
+package cmd_test
+
+import (
+	"context"
+	"fmt"
+	"testing"
+
+	"github.com/markhuang1212/code-grader/backend/cmd"
+	"github.com/markhuang1212/code-grader/types"
+)
+
+func TestCompileUserCode(t *testing.T) {
+	ctx := context.Background()
+	gr := types.GradeRequest{
+		TestCaseName: "example-1",
+		UserCode:     "",
+	}
+
+	_, err := cmd.CompileUserCode(ctx, gr)
+	fmt.Println(err)
+}

install.sh

@@ -9,5 +9,5 @@ sudo apt-get -y upgrade
 sudo apt-get install docker.io
 sudo usermod -aG docker 
 
-docker build 
+docker-compose build 
 docker-compose up

runtime-compile/Dockerfile

@@ -2,15 +2,12 @@ FROM ubuntu:21.04
 
 RUN apt-get update
 RUN apt-get -y upgrade
-RUN apt-get -y install golang ca-certificates build-essential
-
-RUN update-ca-certificates
+RUN apt-get -y install build-essential
 
 WORKDIR /code-grader
 COPY . .
 
 WORKDIR /code-grader/runtime-compile
-RUN go build
 
 USER daemon
-ENTRYPOINT [ "./runtime-compile" ]
+ENTRYPOINT [ "./run.sh" ]

runtime-compile/main.go

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+
+tee > code.txt
+
+cat ${TEST_CASE_DIR}/prepend.txt > main.cpp
+cat code.txt >> main.cpp
+cat ${TEST_CASE_DIR}/append.txt >> main.cpp
+
+${CXX} ${CXXFLAGS} -o /tmp/a.out main.cpp
+
+if [[ $? -ne 0 ]]
+then
+    exit 1
+fi
+
+cat /tmp/a.out

runtime-compile/run.sh

@@ -1,3 +1,3 @@
 # Writing Test Cases
 
-Please refer to this example test case.
+Please refer to this example for writing test case.

testcases/example-1/README.md

@@ -1,17 +1,5 @@
 {
-    "TestCaseName": "ExampleTestCase1",
-    "PreprocessOptions": {
-        "AppendCodePath": "./append.txt",
-        "PrependCodePath": "./prepend.txt"
-    },
-    "CompilerOptions": {
-        "Flags": [
-            "-std=c++11"
-        ]
-    },
     "RuntimeOptions": {
-        "StdinPath": "./input.txt",
-        "StdoutPath": "./output.txt",
         "MemoryLimit": 512,
         "RuntimeLimit": 10
     }

testcases/example-1/testcase.json

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+git pull
+docker-compose build
+docker-compose restart