Bind C warnings (nasa#49)

Using const cea_real[] instead of const cea_array makes it easier
to pass data to the inface without generating incompatible pointer
type warnings.  It also better reflects the design intent; not only
will the pointer not be changed, but the data pointed to will not
be changed.  Updated example 9 to demonstrate that this works without
warnings for both const and non-const data.

Author: btmy87

.github/workflows/basic_build.yml

@@ -379,7 +379,7 @@ jobs:
               fcompiler: intel-classic
               fversion: "2021.9"
           - os: windows-latest
-            toolchain: 
+            toolchain:
               ccompiler: msvc
               cversion: latest
               fcompiler: intel
@@ -405,7 +405,7 @@ jobs:
           path: extern/gfe
           submodules: true
 
-      - name: Set up Fortran compiler 
+      - name: Set up Fortran compiler
         if: ${{ runner.os != 'Windows' || matrix.toolchain.fcompiler != 'gcc' }}
         uses: fortran-lang/setup-fortran@v1
         with:
@@ -464,7 +464,7 @@ jobs:
           cmake --build build/extern/gfe --target install
 
       - name: Configure (linux)
-        if: ${{runner.os != 'Windows' || matrix.toolchain.ccompiler != 'msvc'}} 
+        if: ${{runner.os != 'Windows' || matrix.toolchain.ccompiler != 'msvc'}}
         run: |
           cmake -S . -B build -G Ninja \
             -DCMAKE_PREFIX_PATH=build/install \
@@ -504,6 +504,6 @@ jobs:
         if: runner.os == 'Windows'
         run: |
           ./build/source/cea.exe -h
-      
+
       - name: Run ctest
         run: ctest --test-dir build --output-on-failure

source/bind/c/cea.h

@@ -303,15 +303,15 @@ extern "C"
       const cea_equilibrium_type type,
       const cea_real state1,
       const cea_real state2,
-      const cea_array amounts,
+      const cea_real amounts[],
       cea_eqsolution soln);
 
   cea_err cea_eqsolver_solve_with_partials(
       const cea_eqsolver solver,
       const cea_equilibrium_type type,
       const cea_real state1,
       const cea_real state2,
-      const cea_array amounts,
+      const cea_real amounts[],
       cea_eqsolution soln,
       cea_eqpartials eqpartials);
 
@@ -430,14 +430,14 @@ extern "C"
   cea_err cea_rocket_solver_solve_iac(
       const cea_rocket_solver solver,
       cea_rocket_solution soln,
-      const cea_array weights,
+      const cea_real weights[],
       const cea_real pc,
       // Optional: ignored when n_pi_p == 0 (pi_p may be NULL)
-      const cea_array pi_p,
+      const cea_real pi_p[],
       const cea_int n_pi_p,
-      const cea_array subar,
+      const cea_real subar[],
       const cea_int nsubar,
-      const cea_array supar,
+      const cea_real supar[],
       const cea_int nsupar,
       const cea_int n_frz,
       const cea_real hc_or_tc,
@@ -448,14 +448,14 @@ extern "C"
   cea_err cea_rocket_solver_solve_fac(
       const cea_rocket_solver solver,
       cea_rocket_solution soln,
-      const cea_array weights,
+      const cea_real weights[],
       const cea_real pc,
       // Optional: ignored when n_pi_p == 0 (pi_p may be NULL)
-      const cea_array pi_p,
+      const cea_real pi_p[],
       const cea_int n_pi_p,
-      const cea_array subar,
+      const cea_real subar[],
       const cea_int nsubar,
-      const cea_array supar,
+      const cea_real supar[],
       const cea_int nsupar,
       const cea_int n_frz,
       const cea_real hc_or_tc,
@@ -554,7 +554,7 @@ extern "C"
   cea_err cea_shock_solver_solve(
       const cea_shock_solver solver,
       cea_shock_solution soln,
-      const cea_array weights,
+      const cea_real weights[],
       const cea_real T0,
       const cea_real p0,
       const cea_real mach1_or_u1,
@@ -640,7 +640,7 @@ extern "C"
   cea_err cea_detonation_solver_solve(
       const cea_detonation_solver solver,
       cea_detonation_solution soln,
-      const cea_array weights,
+      const cea_real weights[],
       const cea_real T1,
       const cea_real p1,
       const bool frozen);