Make assert-same-values show what's different

[dmcassel]

The assert-same-values function tells you when the expected doesn't match the actual and shows both sequences. It would be much more helpful if it showed what was different between them.

[rjrudin]

May do this in 1.4.0 if there's an easy way to do something useful. Otherwise will close.

[jamesagardner]

This link may help: https://stackoverflow.com/questions/59772188/how-to-mark-the-differences-between-two-strings

…

On Wed, Aug 9, 2023 at 1:47 PM Rob Rudin ***@***.***> wrote: May do this in 1.4.0 if there's an easy way to do something useful. Otherwise will close. — Reply to this email directly, view it on GitHub <#48 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBA7LRGM2MHZ4VUUYT4PM3XUPEMNANCNFSM4GIS4T6A> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.*** com>

[dmcassel]

I can offer a first pass but don't have time for extensive testing right now:

xquery version "1.0-ml";

(:
 : $seq1 and $seq2 are assumed to be in order, as done https://github.com/marklogic-community/marklogic-unit-test/blob/master/marklogic-unit-test-modules/src/main/ml-modules/root/test/test-helper.xqy#L523-L530. 
:)
declare function local:find-diffs($seq1, $seq2, $diffs) {
  if (fn:empty($seq1) and fn:empty($seq2)) then
    $diffs
  else if (fn:empty($seq1)) then (
    $diffs => map:with("only-in-2", ($diffs => map:get("only-in-2"), $seq2))
  )
  else if (fn:empty($seq2)) then (
    $diffs => map:with("only-in-1", ($diffs => map:get("only-in-1"), $seq1))
  )
  else if (fn:deep-equal(fn:head($seq1), fn:head($seq2))) then
    local:find-diffs(fn:tail($seq1), fn:tail($seq2), $diffs)
  else if (fn:head($seq1) lt fn:head($seq2)) then
    local:find-diffs(fn:tail($seq1), $seq2, $diffs => map:with("only-in-1", ($diffs => map:get("only-in-1"), fn:head($seq1))))
  else
    local:find-diffs($seq1, fn:tail($seq2), $diffs => map:with("only-in-2", ($diffs => map:get("only-in-2"), fn:head($seq2))))
};

let $seq1 := ('a', 'b', 'd')
let $seq2 := ('b', 'c', 'e')
return 
  local:find-diffs($seq1, $seq2, map:map())

This returns

<map:map xmlns:map="http://marklogic.com/xdmp/map" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xs="http://www.w3.org/2001/XMLSchema">
  <map:entry key="only-in-2">
    <map:value xsi:type="xs:string">c</map:value>
    <map:value xsi:type="xs:string">e</map:value>
  </map:entry>
  <map:entry key="only-in-1">
    <map:value xsi:type="xs:string">a</map:value>
    <map:value xsi:type="xs:string">d</map:value>
  </map:entry>
</map:map>

[rjrudin]

DEVEXP-555

[rjrudin]

Holding off on this as we'd like to try implementing assert-same-values with a real quality check first instead of having to sort.