Skip to content

Commit 1c51f56

Browse files
committed
MLE-24892 Cleaning up test dependencies
Unfortunately can't upgrade to JUnit5 in ml-development-tools, far too many breaking changes to fix for now.
1 parent 6f321dd commit 1c51f56

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

marklogic-client-api/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ dependencies {
3838

3939
testImplementation 'org.junit.jupiter:junit-jupiter:5.14.0'
4040

41-
// Forcing junit version to avoid vulnerability with older version in xmlunit
42-
testImplementation 'junit:junit:4.13.2'
4341
testImplementation 'org.xmlunit:xmlunit-legacy:2.10.4'
4442
testImplementation project(':examples')
4543

marklogic-client-api/src/test/java/com/marklogic/client/test/rows/TransformDocTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
import com.marklogic.client.io.marker.AbstractWriteHandle;
1414
import com.marklogic.client.row.RowRecord;
1515
import com.marklogic.client.test.Common;
16-
import com.marklogic.client.test.MarkLogicVersion;
1716
import com.marklogic.client.test.junit5.RequiresML11;
18-
import org.junit.Before;
1917
import org.junit.jupiter.api.BeforeEach;
2018
import org.junit.jupiter.api.Test;
2119
import org.junit.jupiter.api.extension.ExtendWith;

ml-development-tools/build.gradle

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,9 @@ dependencies {
2929
// Sticking with this older version for now as the latest 1.x version introduces breaking changes.
3030
implementation 'com.networknt:json-schema-validator:1.0.88'
3131

32-
// Not yet migrating this project to JUnit 5. Will reconsider it once we have a reason to enhance
33-
// this project.
32+
// Sticking with JUnit 4 as there are no vulnerabilities with it, and shifting to JUnit 5 in this module will be
33+
// a significant and tedious effort.
3434
testImplementation 'junit:junit:4.13.2'
35-
testImplementation 'org.xmlunit:xmlunit-legacy:2.10.4'
36-
testCompileOnly gradleTestKit()
37-
38-
testImplementation "com.squareup.okhttp3:okhttp:${okhttpVersion}"
3935
}
4036

4137
// Added to avoid problem where processResources fails because - somehow - the plugin properties file is getting

0 commit comments

Comments
 (0)