#1265 - New tests for checking NPE

Author: georgeajit

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/BulkIOCallersFnTest.java

@@ -78,6 +78,8 @@ public class BulkIOCallersFnTest extends BasicJavaClientREST {
 
     // Egress error endpoint ConfigName
     private static String JsonEgressErrorConfigName = "DynamicEgressServicesForJsonError";
+    // Ingest error endpoint ConfigName
+    private static String JsonIngestErrorConfigName = "DynamicIngestServicesForTextError";
 
     // Ingest and Egress endpoint ConfigName
     private static String IngestEgressSessionFieldsConfigName = "DynamicIngestEgressSessionFields";
@@ -94,6 +96,7 @@ public class BulkIOCallersFnTest extends BasicJavaClientREST {
     private static String IngestServicesXmlURI = "/dynamic/fntest/DynamicIngestServices/xml/";
     private static String IngestServicesTextURI = "/dynamic/fntest/DynamicIngestServices/text/";
     private static String IngestServicesBinURI = "/dynamic/fntest/DynamicIngestServices/bin/";
+    private static String IngestServicesJsonErrorURI = "/dynamic/fntest/DynamicIngestServicesError/json/";
     //Output URI
     private static String EgressServicesJsonURI = "/dynamic/fntest/DynamicEgressServices/json/";
     private static String EgressServicesJsonErrorURI = "/dynamic/fntest/DynamicEgressServicesError/json/";
@@ -241,6 +244,18 @@ public static void setUp() throws Exception {
         file = null;
         handle = null;
 
+        file = new File(ApiConfigDirPath + JsonIngestErrorConfigName + ".sjs");
+        handle = new FileHandle(file);
+        docMgr.write(IngestServicesJsonErrorURI + JsonIngestErrorConfigName +".sjs", metadataHandle, handle);
+        file = null;
+        handle = null;
+
+        file = new File(ApiConfigDirPath + JsonIngestErrorConfigName + ".api");
+        handle = new FileHandle(file);
+        docMgr.write(IngestServicesJsonErrorURI + JsonIngestErrorConfigName +".api", metadataHandle, handle);
+        file = null;
+        handle = null;
+
         file = new File(ApiConfigDirPath + IngestEgressSessionFieldsConfigName + ".sjs");
         handle = new FileHandle(file);
         docMgr.write(IngestEgressSessionFieldsURI + IngestEgressSessionFieldsConfigName +".sjs", metadataHandle, handle);
@@ -652,6 +667,61 @@ public void TestIngestEgressOnTextDocs() throws Exception {
         }
     }
 
+    // Use /dynamic/fntest/DynamicIngestServices/text/DynamicIngestServicesForTextError.sjs endpoint to test Text Documents ingest
+    // Verify that STOP_ALL_CALLS in client does not throw NPE. Git # 1265
+    @Test
+    public void TestIngestOnTextDocsError() throws Exception {
+        System.out.println("Running TestIngestOnTextDocsError");
+        StringBuilder errorBuf = new StringBuilder();
+        try {
+            int startBatchIdx = 0;
+            int maxDocSize = 100;
+
+            ObjectMapper om = new ObjectMapper();
+            File apiFile = new File(ApiConfigDirPath + JsonIngestErrorConfigName + ".api");
+
+            JsonNode api = om.readTree(new FileReader(apiFile));
+            JacksonHandle jhAPI = new JacksonHandle(api);
+
+            String state = "{\"next\":"+startBatchIdx+"}";
+            String work = "{\"max\":"+maxDocSize+"}";
+
+            InputCaller<String> ingressEndpt = InputCaller.on(dbclient, jhAPI, new StringHandle());
+            InputCaller.BulkInputCaller<String> inputbulkCaller = ingressEndpt.bulkCaller(ingressEndpt.newCallContext()
+                    .withEndpointConstantsAs(work.getBytes())
+                    .withEndpointStateAs(state));
+            String[] strContent = { "This is first test document",
+                    "This is second test document",
+                    "This is third test document",
+                    "This is fourth test document",
+                    "This is fifth test document"
+            };
+            InputCaller.BulkInputCaller.ErrorListener InerrorListener =
+                    (retryCount, throwable, callContext, inputHandles)
+                            -> {
+                        for(BufferableHandle h:inputHandles) {
+                            errorBuf.append(h.toString());
+                        }
+                        return IOEndpoint.BulkIOEndpointCaller.ErrorDisposition.STOP_ALL_CALLS;
+                    };
+
+            Stream<String> input = Stream.of(strContent);
+            input.forEach(inputbulkCaller::accept);
+            inputbulkCaller.setErrorListener(InerrorListener);
+            inputbulkCaller.awaitCompletion();
+            String errStr = errorBuf.toString();
+            //System.out.println("Error buffer when STOP_ALL_CALLS " + errorBuf.toString());
+            Assert.assertTrue(!errStr.contains("Exception"));
+            Assert.assertTrue(errStr.isEmpty());
+
+        } catch (Exception e) {
+            e.printStackTrace();
+        }
+        finally {
+            System.out.println("End of TestIngestEgressOnTextDocs");
+        }
+    }
+
     // Use /dynamic/fntest/DynamicIngestServices/bin/DynamicIngestServicesForBin.sjs endpoint to test Binary Documents ingest
     @Test
     public void TestIngestEgressOnBinDocs() throws Exception {

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/data/api/DynamicIngestServicesForTextError.api

@@ -0,0 +1,32 @@
+{
+  "endpoint": "/dynamic/fntest/DynamicIngestServices/text/DynamicIngestServicesForTextError.sjs",
+  "params": [ {
+    "name":     "endpointState",
+    "datatype": "jsonDocument",
+    "multiple": false,
+    "nullable": true
+    }, {
+    "name":     "session",
+    "datatype": "session",
+    "multiple": false,
+    "nullable": true
+    }, {
+    "name":     "endpointConstants",
+    "datatype": "jsonDocument",
+    "multiple": false,
+    "nullable": true
+    }, {
+    "name":     "input",
+    "datatype": "textDocument",
+    "multiple": true,
+    "nullable": true
+  } ],
+  "return": {
+    "datatype": "jsonDocument",
+    "multiple": false,
+    "nullable": true
+  },
+  "$bulk":{
+    "inputBatchSize":1
+  }
+}

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/data/api/DynamicIngestServicesForTextError.sjs

@@ -0,0 +1,28 @@
+'use strict';
+var endpointState; // jsonDocument?
+
+var workUnit;      // jsonDocument?
+var input;         // binaryDocument*
+declareUpdate();
+
+const work = fn.head(xdmp.fromJSON(endpointConstants));
+const state = fn.head(xdmp.fromJSON(endpointState));
+state.next = state.next + 1;
+
+const inputs =
+    (input instanceof Sequence) ? input.toArray().map(item => fn.head(item)) :
+    (input instanceof Document) ? input :
+                                   {UNKNOWN: input} ;
+let returnValue = null;
+if (state.next < work.max) {
+if (Array.isArray(inputs)) {
+var i;
+fn.error(xs.QName("XDMP-INVALDATE"), "QA Generated doc write error");
+}
+else
+{
+  fn.error(xs.QName("XDMP-INVALDATE"), "QA Generated doc write error");
+}
+    returnValue = state;
+}
+returnValue;