MLE-23146 Addressed unchecked warnings in src/main/java

Author: rjrudin

build.gradle

@@ -4,49 +4,50 @@
 // used for that. So we have to add the properties plugin to the buildscript classpath and then apply the properties
 // plugin via subprojects below.
 buildscript {
-    repositories {
-        maven {
-            url = "https://plugins.gradle.org/m2/"
-        }
-    }
-    dependencies {
-        classpath "net.saliman:gradle-properties-plugin:1.5.2"
-    }
+	repositories {
+		maven {
+			url = "https://plugins.gradle.org/m2/"
+		}
+	}
+	dependencies {
+		classpath "net.saliman:gradle-properties-plugin:1.5.2"
+	}
 }
 
 subprojects {
-    apply plugin: "net.saliman.properties"
-    apply plugin: 'java'
+	apply plugin: "net.saliman.properties"
+	apply plugin: 'java'
 
- 	tasks.withType(JavaCompile) {
-    	options.encoding = 'UTF-8'
-  	}
+	tasks.withType(JavaCompile) {
+		options.encoding = 'UTF-8'
+		options.compilerArgs += ["-Xlint:unchecked"]
+	}
 
-    // To ensure that the Java Client continues to support Java 8, both source and target compatibility are set to 1.8.
-    java {
-        sourceCompatibility = 1.8
-        targetCompatibility = 1.8
-    }
+	// To ensure that the Java Client continues to support Java 8, both source and target compatibility are set to 1.8.
+	java {
+		sourceCompatibility = 1.8
+		targetCompatibility = 1.8
+	}
 
-    configurations {
-        testImplementation.extendsFrom compileOnly
-    }
+	configurations {
+		testImplementation.extendsFrom compileOnly
+	}
 
-    repositories {
-        mavenLocal()
-        mavenCentral()
-    }
+	repositories {
+		mavenLocal()
+		mavenCentral()
+	}
 
 	test {
 		systemProperty "file.encoding", "UTF-8"
 		systemProperty "javax.xml.stream.XMLOutputFactory", "com.sun.xml.internal.stream.XMLOutputFactoryImpl"
 	}
 
 	// Until we do a cleanup of javadoc errors, the build (and specifically the javadoc task) fails on Java 11
-    // and higher. Preventing that until the cleanup can occur.
-    javadoc.failOnError = false
+	// and higher. Preventing that until the cleanup can occur.
+	javadoc.failOnError = false
 
-    // Ignores warnings on param tags with no descriptions. Will remove this once javadoc errors are addressed.
-    // Until then, it's just a lot of noise.
-    javadoc.options.addStringOption('Xdoclint:none', '-quiet')
+	// Ignores warnings on param tags with no descriptions. Will remove this once javadoc errors are addressed.
+	// Until then, it's just a lot of noise.
+	javadoc.options.addStringOption('Xdoclint:none', '-quiet')
 }

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/HostAvailabilityListener.java

@@ -141,7 +141,8 @@ public HostAvailabilityListener withMinHosts(int numHosts) {
    *
    * @return this instance (for method chaining)
    */
-  public HostAvailabilityListener withHostUnavailableExceptions(Class<Throwable>... exceptionTypes) {
+  @SafeVarargs
+  public final HostAvailabilityListener withHostUnavailableExceptions(Class<Throwable>... exceptionTypes) {
     hostUnavailableExceptions = new ArrayList<>();
     for ( Class<Throwable> exception : exceptionTypes ) {
       hostUnavailableExceptions.add(exception);

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/JSONSplitter.java

@@ -154,14 +154,15 @@ public Stream<T> split(JsonParser input) throws IOException {
      *                  files.The splitFilename could either be provided here or in user-defined UriMaker.
      * @return a stream of DocumentWriteOperation to write to database
      */
+	@SuppressWarnings("unchecked")
     public Stream<DocumentWriteOperation> splitWriteOperations(JsonParser input, String splitFilename) {
         if (input == null) {
             throw new IllegalArgumentException("Input cannot be null");
         }
         count = 0;
 
         this.splitFilename = splitFilename;
-        JSONSplitter.DocumentWriteOperationSpliterator spliterator =
+        JSONSplitter.DocumentWriteOperationSpliterator<T> spliterator =
                 new JSONSplitter.DocumentWriteOperationSpliterator<>(this, input);
         return StreamSupport.stream(spliterator, true);
     }

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/PathSplitter.java

@@ -104,6 +104,7 @@ public Stream<DocumentWriteOperation> splitDocumentWriteOperations(Stream<Path>
         return paths.flatMap(this::flatMapDocumentWriteOperations);
     }
 
+	@SuppressWarnings("unchecked")
     private Stream<? extends AbstractWriteHandle> flatMapHandles(Path path) {
         String extension = getExtension(path);
         Splitter splitter = lookupSplitter(extension);
@@ -119,6 +120,7 @@ private Stream<? extends AbstractWriteHandle> flatMapHandles(Path path) {
         }
     }
 
+	@SuppressWarnings("unchecked")
     private Stream<DocumentWriteOperation> flatMapDocumentWriteOperations(Path path)  {
         String extension = getExtension(path);
         Splitter splitter = lookupSplitter(extension);
@@ -153,6 +155,7 @@ private String getExtension(Path path) {
         return matcher.group(1);
     }
 
+	@SuppressWarnings("unchecked")
     private Splitter<? extends AbstractWriteHandle> lookupSplitter(String extension) {
         Splitter splitter = splitterMap.get(extension);
         if (splitter == null && splitterMap.get(DEFAULT_SPLITTER_KEY) != null) {

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/ProgressListener.java

@@ -55,6 +55,7 @@ public ProgressListener() {
 	 * Use this constructor for when the total number of results isn't known ahead of time.
 	 * @param consumers one or more callbacks for progress updates
 	 */
+	@SafeVarargs
 	public ProgressListener(Consumer<ProgressUpdate>... consumers) {
 		this(0, consumers);
 	}
@@ -65,6 +66,7 @@ public ProgressListener(Consumer<ProgressUpdate>... consumers) {
 	 * @param totalResults the total number of results that is the processing goal
 	 * @param consumers one or more callbacks for progress updates
 	 */
+	@SafeVarargs
 	public ProgressListener(long totalResults, Consumer<ProgressUpdate>... consumers) {
 		this.totalResults = totalResults;
 		for (Consumer<ProgressUpdate> consumer : consumers) {

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/RowBatcher.java

@@ -218,7 +218,8 @@ public interface RowBatcher<T> extends Batcher {
      * rows when more than one callback function is needed.
      * @param listeners the success listeners
      */
-    void setSuccessListeners(RowBatchSuccessListener<T>... listeners);
+	@SuppressWarnings("unchecked")
+	void setSuccessListeners(RowBatchSuccessListener<T>... listeners);
     /**
      * Specifies the callback functions for errors when more than
      * one callback function is needed.

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/XMLSplitter.java

@@ -483,6 +483,7 @@ private static class DocumentWriteOperationSpliterator<T extends XMLWriteHandle>
             super(xmlSplitter, input);
         }
         @Override
+		@SuppressWarnings("unchecked")
         public boolean tryAdvance(Consumer<? super DocumentWriteOperation> action) {
 
             T handle = (T) getNextHandle();

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/impl/BatchImpl.java

@@ -24,6 +24,7 @@ public BatchImpl(Class<T> as) {
   }
 
   @Override
+  @SuppressWarnings("unchecked")
   public T[] getItems() {
     if (items == null) {
       return (T[]) Array.newInstance(as, 0);
@@ -35,15 +36,22 @@ public BatchImpl<T> withItems(T[] items) {
     return this;
   }
 
+	@SuppressWarnings("unchecked")
   public BatchImpl<T> withClient(DatabaseClient client) {
     return (BatchImpl<T>) super.withClient(client);
   }
+
+	@SuppressWarnings("unchecked")
   public BatchImpl<T> withTimestamp(Calendar timestamp) {
     return (BatchImpl<T>) super.withTimestamp(timestamp);
   }
+
+	@SuppressWarnings("unchecked")
   public BatchImpl<T> withJobTicket(JobTicket jobTicket) {
     return (BatchImpl<T>) super.withJobTicket(jobTicket);
   }
+
+	@SuppressWarnings("unchecked")
   public BatchImpl<T> withJobBatchNumber(long jobBatchNumber) {
     return (BatchImpl<T>) super.withJobBatchNumber(jobBatchNumber);
   }

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/impl/RowBatcherImpl.java

@@ -44,7 +44,7 @@ class RowBatcherImpl<T>  extends BatcherImpl implements RowBatcher<T> {
     private final AtomicLong failedBatches = new AtomicLong(0);
     private final AtomicInteger runningThreads = new AtomicInteger(0);
     private RowBatchFailureListener[] failureListeners;
-    private RowBatchSuccessListener[] successListeners;
+    private RowBatchSuccessListener<T>[] successListeners;
 
     private RawPlanDefinition pagedPlan;
     private long rowCount = 0;
@@ -162,6 +162,7 @@ public RowBatcher<T> withThreadCount(int threadCount) {
     }
 
     @Override
+	@SuppressWarnings("unchecked")
     public RowBatcher<T> onSuccess(RowBatchSuccessListener listener) {
         requireNotStarted("Must set success listener before starting job");
         if (listener == null) {
@@ -212,30 +213,38 @@ public RowBatcher<T> withConsistentSnapshot() {
     }
 
     @Override
-    public RowBatchSuccessListener[] getSuccessListeners() {
+	@SuppressWarnings("unchecked")
+    public RowBatchSuccessListener<T>[] getSuccessListeners() {
         return successListeners;
     }
+
     @Override
     public RowBatchFailureListener[] getFailureListeners() {
         return failureListeners;
     }
+
+	@SafeVarargs
     @Override
-    public void setSuccessListeners(RowBatchSuccessListener... listeners) {
+    public final void setSuccessListeners(RowBatchSuccessListener<T>... listeners) {
         requireNotStarted("Must set success listeners before starting job");
         this.successListeners = listeners;
     }
+
+	@SafeVarargs
     @Override
-    public void setFailureListeners(RowBatchFailureListener... listeners) {
+    public final void setFailureListeners(RowBatchFailureListener... listeners) {
         requireNotStarted("Must set failure listeners before starting job");
         this.failureListeners = listeners;
     }
     private void initRequestEvent(RowBatchEventImpl event) {
         event.withClient(getPrimaryClient());
         event.withJobTicket(getJobTicket());
     }
+
+	@SuppressWarnings("unchecked")
     private void notifySuccess(RowBatchSuccessListener.RowBatchResponseEvent<T> event) {
         if (successListeners == null || successListeners.length == 0) return;
-        for (RowBatchSuccessListener successListener: successListeners) {
+        for (RowBatchSuccessListener<T> successListener: successListeners) {
             try {
                 successListener.processEvent(event);
             } catch(Throwable e) {
@@ -413,6 +422,7 @@ public synchronized void start(JobTicket ticket) {
         }
     }
 
+	@SuppressWarnings("unchecked")
     private boolean readRows(RowBatchCallable<T> callable) {
         // assumes a batch size of at least 2 to avoid unsigned overflow
         long currentBatch = this.batchNum.incrementAndGet();
@@ -538,9 +548,12 @@ public synchronized RowBatcher<T> withForestConfig(ForestConfiguration forestCon
         return this;
     }
 
+	@SuppressWarnings("unchecked")
     private void submit(Callable<Boolean> callable) {
         submit(new FutureTask(callable));
     }
+
+	@SuppressWarnings("unchecked")
     private void submit(FutureTask<Boolean> task) {
         threadPool.execute(task);
     }
@@ -552,10 +565,14 @@ static private class RowBatchCallable<T> implements Callable<Boolean> {
             this.rowBatcher = rowBatcher;
             this.handle = handle;
         }
+
+		@SuppressWarnings("unchecked")
         private ContentHandle<T> getHandle() {
             return handle;
         }
+
         @Override
+		@SuppressWarnings("unchecked")
         public Boolean call() {
             try {
                 return rowBatcher.readRows(this);

marklogic-client-api/src/main/java/com/marklogic/client/dataservices/InputCaller.java

@@ -25,6 +25,7 @@ public interface InputCaller<I> extends IOEndpoint {
 	 * @param <I>  the input content representation (such as String)
 	 * @return  the InputCaller instance for calling the endpoint.
 	 */
+	@SuppressWarnings("unchecked")
 	static <I> InputCaller<I> on(DatabaseClient client, JSONWriteHandle apiDecl, BufferableContentHandle<I,?> inputHandle) {
 		return new InputEndpointImpl(client, apiDecl, new HandleProvider.ContentHandleProvider<>(inputHandle,null));
 	}
@@ -40,6 +41,7 @@ static <I> InputCaller<I> on(DatabaseClient client, JSONWriteHandle apiDecl, Buf
 	 * @param <I> the input handle
 	 * @return the InputOutputCaller instance for calling the endpoint.
 	 */
+	@SuppressWarnings("unchecked")
 	static <IC,IR,I extends BufferableContentHandle<IC,IR>> InputCaller<I> onHandles(
 			DatabaseClient client, JSONWriteHandle apiDecl, I inputHandle
 	) {