#725 - Tests for evalAs(Class) that return some non-streaming responses

at least as long as 17,400 chars.

Author: georgeajit

test-complete/src/test/java/com/marklogic/client/functionaltest/TestEvalJavaScript.java

@@ -40,6 +40,7 @@
 import org.w3c.dom.Document;
 import org.xml.sax.InputSource;
 
+import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.marklogic.client.DatabaseClient;
 import com.marklogic.client.DatabaseClientFactory;
@@ -351,6 +352,7 @@ public void testJSReturningDifferentTypesOrder1() throws KeyManagementException,
         System.out.println("Something went wrong");
       }
     }
+    evr.close();
   }
 
   // This test is intended to test eval(T handle), passing input stream handle
@@ -390,6 +392,7 @@ public void testJSReturningDifferentTypesOrder2() throws KeyManagementException,
           System.out.println("Something went wrong");
         }
       }
+      evr.close();
     } catch (Exception e) {
       throw e;
     } finally {
@@ -439,6 +442,7 @@ public void testJSDifferentVariableTypes() throws KeyManagementException, NoSuch
       System.out.println(new ObjectMapper().createObjectNode().nullNode().toString());
       EvalResultIterator evr = evl.eval();
       this.validateReturnTypes(evr);
+      evr.close();
 
     } catch (Exception e) {
       throw e;
@@ -486,6 +490,7 @@ public void testJSDifferentVariableTypesWithNulls() throws KeyManagementExceptio
       System.out.println(new ObjectMapper().createObjectNode().nullNode().toString());
       EvalResultIterator evr = evl.eval();
       this.validateReturnTypes(evr);
+      evr.close();
 
     } catch (Exception e) {
       throw e;
@@ -528,6 +533,7 @@ public void testJSDifferentVariableTypesNoNullNodes() throws KeyManagementExcept
       System.out.println(new ObjectMapper().createObjectNode().nullNode().toString());
       EvalResultIterator evr = evl.eval();
       this.validateReturnTypes(evr);
+      evr.close();
 
     } catch (Exception e) {
       throw e;
@@ -551,7 +557,7 @@ public void testMultipleJSfnOnServerEval() {
         .evalAs(String.class);
     System.out.println(response3);
   }
-
+  
   // Issue 30209 ,external variable passing is not working so I have test cases
   // where it test to see we can invoke a module
   @Test
@@ -605,6 +611,7 @@ public void testJSReturningDifferentTypesOrder3fromModules() throws Exception {
           System.out.println("Something went wrong");
         }
       }
+      evr.close();
     } catch (Exception e) {
       throw e;
     } finally {
@@ -614,4 +621,69 @@ public void testJSReturningDifferentTypesOrder3fromModules() throws Exception {
       moduleClient.release();
     }
   }
+  
+  /*
+   * Test is intended to test ServerEvaluationCall.evalAs(Class<T>) closing underlying streams prematurely 
+   * Git Issue 725
+   */
+  @Test
+  public void testStreamClosingWithEvalAs() throws KeyManagementException, NoSuchAlgorithmException, Exception {
+    try {
+      String query1 = 
+           "var phrase = 'MarkLogic Corp';"
+          + "var repeat = 10;"
+          + "for (var i = 0; i < repeat; i++) {"
+          + "phrase += phrase.concat(phrase);"
+          + "}"          
+          + "phrase;";
+      
+      String query2 = 
+              "var phrase2 = 'Java Client API';"
+             + "var repeat = 10;"
+             + "for (var i = 0; i < repeat; i++) {"
+             + "phrase2 += phrase2.concat(phrase2);"
+             + "}"          
+             + "var jsStr = JSON.stringify(phrase2);"
+             + "jsStr;";
+
+      ServerEvaluationCall evl = client.newServerEval().javascript(query1);
+      
+      // Using evalAs(String.class)
+      String evr = evl.evalAs(String.class);
+      
+      int nLen = evr.length();
+      String firstFiftyChars = evr.substring(0, 50);
+      String lastTenChars = evr.substring(evr.length() - 10);
+      
+      // Make sure we can access results that are greater than 17,400 chars. See Git Issue 725.
+      System.out.println("String length is " + nLen);
+      System.out.println("First Fifty String output is " + firstFiftyChars);
+      System.out.println("Last Ten String output is " + lastTenChars);
+      
+      assertTrue("String length incorrect", nLen==826686);
+      assertTrue("First Fifty String output incorrect ", firstFiftyChars.equalsIgnoreCase("MarkLogic CorpMarkLogic CorpMarkLogic CorpMarkLogi"));
+      assertTrue("Last Ten String output incorrect ", lastTenChars.equalsIgnoreCase("Logic Corp"));
+      
+      // Using evalAs(JsonNode.class)
+      ServerEvaluationCall ev2 = client.newServerEval().javascript(query2);
+      JsonNode jNode = ev2.evalAs(JsonNode.class);
+      
+      String jsonStr = jNode.asText();
+      int nJLen = jsonStr.length();
+      String firstFiftyCharsJson = jsonStr.substring(0, 50);
+      String lastTenCharsJson = jsonStr.substring(jsonStr.length() - 10);
+      
+      // Make sure we can access results that are greater than 17,400 chars. See Git Issue 725.
+      System.out.println("JSON String length is " + nJLen);
+      System.out.println("First Fifty String JSON output is " + firstFiftyCharsJson);
+      System.out.println("Last Ten String JSON output is " + lastTenCharsJson);
+      
+      assertTrue("JSON String length incorrect", nJLen==885735);
+      assertTrue("First Fifty JSON String output incorrect ", firstFiftyCharsJson.equalsIgnoreCase("Java Client APIJava Client APIJava Client APIJava "));
+      assertTrue("Last Ten JSON String output incorrect ", lastTenCharsJson.equalsIgnoreCase("Client API"));
+      
+    } catch (Exception e) {
+      throw e;
+    }
+  }
 }

test-complete/src/test/java/com/marklogic/client/functionaltest/TestEvalXquery.java

@@ -229,6 +229,7 @@ else if (er.getType().equals(Type.STRING)) {
         assertFalse("getting in else part, missing a type  ", true);
       }
     }
+    evr.close();
   }
 
   // This test intended to verify a simple xquery for inserting and reading
@@ -291,8 +292,8 @@ else if (er.getType().equals(Type.TEXTNODE)) {
       } else {
         System.out.println("Something went wrong");
       }
-
     }
+    evr.close();
   }
 
   // This test is intended to test eval(T handle), passing input stream handle
@@ -303,14 +304,16 @@ public void testXqueryReturningDifferentTypesAndFormatsWithHandle() throws KeyMa
     InputStream inputStream = new FileInputStream("src/test/java/com/marklogic/client/functionaltest/data/xqueries.txt");
     InputStreamHandle ish = new InputStreamHandle();
     ish.set(inputStream);
+    EvalResultIterator evr = null;
 
     try {
-      EvalResultIterator evr = client.newServerEval().xquery(ish).eval();
+      evr = client.newServerEval().xquery(ish).eval();
       this.validateReturnTypes(evr);
     } catch (Exception e) {
       throw e;
     } finally {
       inputStream.close();
+      evr.close();
     }
   }
 
@@ -412,6 +415,7 @@ else if (er.getType().equals(Type.TEXTNODE)) {
           System.out.println("No corresponding type found for :" + er.getType());
         }
       }
+      evr.close();
 
     } catch (Exception e) {
       throw e;
@@ -455,6 +459,7 @@ public void testXqueryWithExtVarAsNode() throws KeyManagementException, NoSuchAl
         // System.out.println("Type XML  :"+convertXMLDocumentToString(dh.get()));
         assertEquals("document has content", "<foo attr=\"attribute\"><?processing instruction?><!--comment-->test1</foo>", convertXMLDocumentToString(dh.get()));
       }
+      evr.close();
     } catch (Exception e) {
       throw e;
     }
@@ -493,6 +498,7 @@ public void testXqueryInvokeModuleRetDiffTypes() throws KeyManagementException,
           .addVariableAs("myNull", (String) null);
       EvalResultIterator evr = evl.eval();
       this.validateReturnTypes(evr);
+      evr.close();
 
     } catch (Exception e) {
       throw e;