Skip to content

Commit c2d0611

Browse files
authored
Merge pull request #1563 from marklogic/feature/hsqldb
Disabling JdbcCookbookTest
2 parents b3c58d7 + 05374f7 commit c2d0611

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

examples/build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@ dependencies {
2020
api 'org.slf4j:slf4j-api:1.7.36'
2121
api 'com.fasterxml.jackson.core:jackson-databind:2.14.1'
2222

23-
// hsqldb 2.6+ requires Java 11+
24-
api 'org.hsqldb:hsqldb:2.5.2'
23+
// hsqldb < 2.7 has a High CVE - https://nvd.nist.gov/vuln/detail/CVE-2022-41853 .
24+
// And hsqldb 2.6+ requires Java 11+. So this is ignored, along with the associated test,
25+
// until the Java Client can drop Java 8 support.
26+
// api 'org.hsqldb:hsqldb:2.7.1'
2527

2628
api 'org.jdom:jdom2:2.0.6.1'
2729
api 'org.dom4j:dom4j:2.1.3'

marklogic-client-api/src/test/java/com/marklogic/client/test/example/cookbook/JdbcCookbookTest.java

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,12 @@
1717

1818
import com.marklogic.client.example.cookbook.Util;
1919
import com.marklogic.client.example.cookbook.Util.ExampleProperties;
20-
import com.marklogic.client.example.cookbook.datamovement.*;
21-
import org.hsqldb.server.Server;
20+
import com.marklogic.client.example.cookbook.datamovement.BulkExportToJdbc;
21+
import com.marklogic.client.example.cookbook.datamovement.BulkLoadFromJdbcRaw;
22+
import com.marklogic.client.example.cookbook.datamovement.BulkLoadFromJdbcWithJoins;
23+
import com.marklogic.client.example.cookbook.datamovement.BulkLoadFromJdbcWithSimpleJoins;
24+
import com.marklogic.client.example.cookbook.datamovement.IncrementalLoadFromJdbc;
25+
import org.junit.jupiter.api.Disabled;
2226
import org.junit.jupiter.api.Test;
2327
import org.springframework.jdbc.core.JdbcTemplate;
2428
import org.springframework.jdbc.datasource.DriverManagerDataSource;
@@ -29,19 +33,19 @@
2933
public class JdbcCookbookTest {
3034

3135
class Database {
32-
Server hsqlDBServer;
36+
// Server hsqlDBServer;
3337
JdbcTemplate jdbcTemplate;
3438
Database() throws IOException {
3539
setupHSQLDBServer();
3640
jdbcTemplate = new JdbcTemplate(getDataSource());
3741
}
3842

3943
private void setupHSQLDBServer() {
40-
hsqlDBServer = new Server();
41-
hsqlDBServer.setDatabaseName(0, "employees");
42-
hsqlDBServer.setDatabasePath(0, "mem:employees");
43-
hsqlDBServer.setPort(9002);
44-
hsqlDBServer.start();
44+
// hsqlDBServer = new Server();
45+
// hsqlDBServer.setDatabaseName(0, "employees");
46+
// hsqlDBServer.setDatabasePath(0, "mem:employees");
47+
// hsqlDBServer.setPort(9002);
48+
// hsqlDBServer.start();
4549
}
4650

4751
private DataSource getDataSource() throws IOException {
@@ -54,10 +58,12 @@ public void execute(String query) {
5458
}
5559

5660
public void tearDown() {
57-
hsqlDBServer.stop();
61+
// hsqlDBServer.stop();
5862
}
5963
}
6064

65+
@Disabled("Disabled until the Java Client drops Java 8 support, which then allows for the most recent version " +
66+
"of org.hsqldb:hsqldb to be used, thus avoiding a High CVE.")
6167
@Test
6268
public void testMain() throws Exception {
6369
Database hsqlDB = new Database();

0 commit comments

Comments
 (0)