fix #762 - throw ForbiddenUserException when 403 is returned and it's not a content version required

Author: sammefford

src/main/java/com/marklogic/client/impl/OkHttpServices.java

@@ -1471,10 +1471,6 @@ private TemporalDescriptor putPostDocumentImpl(RequestLogger reqlog, String meth
         throw new FailedRequestException(
           "Content version required to write document", failure);
       }
-      throw new FailedRequestException(
-        "Precondition required to write document", failure);
-    } else if (status == STATUS_FORBIDDEN) {
-      FailedRequest failure = extractErrorFields(response);
       throw new ForbiddenUserException(
         "User is not allowed to write documents", failure);
     }
@@ -3878,8 +3874,6 @@ private Request.Builder addTransactionScopedCookies(Request.Builder requestBldr,
         if ( cookie.getMaxAge() == 0 ) {
           continue;
         }
-        // TODO: eval if we need handling for MIN_VALUE
-        // else if ( cookie.getMaxAge() == Integer.MIN_VALUE ) {
         // don't forward the cookie if it has a max age and we're past the max age
         if ( cookie.getMaxAge() > 0 ) {
           Calendar expiration = (Calendar) ((TransactionImpl) transaction).getCreatedTimestamp().clone();

src/test/java/com/marklogic/client/test/InvalidUserTest.java

@@ -28,6 +28,7 @@
 import com.marklogic.client.ForbiddenUserException;
 import com.marklogic.client.DatabaseClientFactory.Authentication;
 import com.marklogic.client.document.TextDocumentManager;
+import com.marklogic.client.io.DocumentMetadataHandle;
 import com.marklogic.client.io.StringHandle;
 
 public class InvalidUserTest {
@@ -76,6 +77,17 @@ public void test_issue_762() {
             assertNotNull("Error Message is null", message);
             assertTrue("Error Message", message.equals("SEC-PRIV"));
             assertTrue("Status code", (statusCode == 403));
+            try {
+                DocumentMetadataHandle metadata = new DocumentMetadataHandle().withQuality(3);
+                readOnlyClient.newDocumentManager().writeAs("test.txt", metadata, "test");
+                fail("reader could write a document with metadata, but shouldn't be able to");
+            } catch (ForbiddenUserException e2) {
+                message = e2.getFailedRequest().getMessageCode();
+                statusCode = e2.getFailedRequest().getStatusCode();
+                assertNotNull("Error Message is null", message);
+                assertTrue("Error Message", message.equals("SEC-PRIV"));
+                assertTrue("Status code", (statusCode == 403));
+            }
         } finally {
             readOnlyClient.release();
         }