Skip to content

Commit 34ffbce

Browse files
committed
Fixed two sonar code smells
The 1.9.0 Wiki page has been updated to include a note about the DHF support.
1 parent 2f3952d commit 34ffbce

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/main/java/com/marklogic/kafka/connect/sink/RunFlowWriteBatchListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ public RunFlowWriteBatchListener(String flowName, List<String> steps, DatabaseCl
6363
public void processEvent(WriteBatch batch) {
6464
FlowInputs inputs = buildFlowInputs(batch);
6565

66-
// TODO When this was originally created for DHF 5.2, basic/digest auth were required. Need to support all
67-
// auth techniques.
66+
// Current plan for 1.9.0 is to support Java Client 6.1.0, at which point we may be able to support any auth
67+
// technique here as well.
6868
FlowRunner flowRunner = new FlowRunnerImpl(HubClient.withHubClientConfig(new HubClientConfig(
6969
databaseClientConfig.getHost(),
7070
databaseClientConfig.getUsername(),

src/main/java/com/marklogic/kafka/connect/sink/WriteBatcherSinkTask.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
package com.marklogic.kafka.connect.sink;
22

33
import com.marklogic.client.DatabaseClient;
4-
import com.marklogic.client.datamovement.*;
4+
import com.marklogic.client.datamovement.DataMovementManager;
5+
import com.marklogic.client.datamovement.WriteBatch;
6+
import com.marklogic.client.datamovement.WriteBatcher;
7+
import com.marklogic.client.datamovement.WriteEvent;
8+
import com.marklogic.client.datamovement.WriteFailureListener;
59
import com.marklogic.client.document.ServerTransform;
610
import com.marklogic.client.ext.DatabaseClientConfig;
711
import com.marklogic.client.ext.DefaultConfiguredDatabaseClientFactory;
@@ -16,7 +20,6 @@
1620
import org.apache.kafka.connect.runtime.InternalSinkRecord;
1721
import org.apache.kafka.connect.sink.ErrantRecordReporter;
1822
import org.apache.kafka.connect.sink.SinkRecord;
19-
import org.slf4j.LoggerFactory;
2023
import org.springframework.util.StringUtils;
2124

2225
import java.io.IOException;
@@ -28,7 +31,7 @@
2831
import java.util.Optional;
2932
import java.util.function.BiConsumer;
3033

31-
import static com.marklogic.kafka.connect.sink.AbstractSinkTask.*;
34+
import static com.marklogic.kafka.connect.sink.AbstractSinkTask.MARKLOGIC_WRITE_FAILURE;
3235

3336
/**
3437
* Uses MarkLogic's Data Movement SDK (DMSDK) to write data to MarkLogic.

0 commit comments

Comments
 (0)