MLE-12345 Fixing weird plugin classpath issue #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR converts the test-app directory from a standalone Gradle project into a subproject by removing its independent Gradle wrapper files and including it in the root project's settings. This resolves classpath issues and enables running mlDeploy from the root directory.
- Removed Gradle wrapper files from test-app (gradlew, gradlew.bat, gradle-wrapper.properties)
- Added test-app as a subproject in root settings.gradle
- Updated test-app .gitignore to ignore Gradle wrapper files
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-app/gradlew.bat | Removed Windows Gradle wrapper script |
| test-app/gradlew | Removed Unix Gradle wrapper script |
| test-app/gradle/wrapper/gradle-wrapper.properties | Removed Gradle wrapper configuration |
| test-app/.gitignore | Added Gradle wrapper files to ignore list |
| settings.gradle | Included test-app as a subproject |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
BillFarber
approved these changes
Oct 1, 2025
This allows for test-app to be a subproject, allowing a developer to run `mlDeploy` from the root directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for test-app to be a subproject, allowing a developer to run
mlDeployfrom the root directory.