added changes as per pr review

Author: Barkha Choithani

charts/templates/statefulset.yaml

@@ -29,28 +29,31 @@ spec:
           - sh
           - '-c'
           - |
-            echo '### Begin init container execution ###'
+            log () {
+                      local TIMESTAMP=$(date +"%Y-%m-%d %T.%3N")
+                      echo "${TIMESTAMP}  $@"
+                    }
+            log "Info: [initContainer] Begin init container configure-group execution"
             if [[ $POD_NAME != *-0 ]]; then
-                echo "This is not a first host in this cluster, not configuring group."
+              log "Info: [initContainer] Skipping creation of group $MARKLOGIC_GROUP as $POD_NAME is not the first node in the group."
             else
               HOST_RESP_CODE=`curl --anyauth -m 20 -s -o /dev/null -w "%{http_code}" -X GET http://${MARKLOGIC_BOOTSTRAP_HOST}:8002/manage/v2/hosts --anyauth --user ${MARKLOGIC_ADMIN_USERNAME}:${MARKLOGIC_ADMIN_PASSWORD}`
               if [[ ${HOST_RESP_CODE} -ne 200 ]]; then
-                echo "Bootstrap host not found."
+                log "Error: [initContainer] Bootstrap host $MARKLOGIC_BOOTSTRAP_HOST not found."
               else
-                echo "Configuring group on the MarkLogic cluster."
                 GROUP_CFG_TEMPLATE='{"group-name":"%s"}'
                 GROUP_CFG=$(printf "$GROUP_CFG_TEMPLATE" "$MARKLOGIC_GROUP")
                 GROUP_RESP_CODE=`curl --anyauth -m 20 -s -o /dev/null -w "%{http_code}" -X GET http://${MARKLOGIC_BOOTSTRAP_HOST}:8002/manage/v2/groups/${MARKLOGIC_GROUP} --anyauth --user ${MARKLOGIC_ADMIN_USERNAME}:${MARKLOGIC_ADMIN_PASSWORD}`
 
                 if [[ ${GROUP_RESP_CODE} -eq 200 ]]; then
-                  echo "Group $MARKLOGIC_GROUP is already configured on the MarkLogic cluster." 
+                  log "Info: [initContainer] Skipping creation of group $MARKLOGIC_GROUP as it already exists on the MarkLogic cluster." 
                 else
-                  echo "Group $MARKLOGIC_GROUP does not exist, creating $MARKLOGIC_GROUP on the MarkLogic cluster"
+                  log "Info: [initContainer] Group $MARKLOGIC_GROUP does not exist, creating $MARKLOGIC_GROUP on the MarkLogic cluster."
                   curl --anyauth --user ${MARKLOGIC_ADMIN_USERNAME}:${MARKLOGIC_ADMIN_PASSWORD} -m 20 -s -X POST -d "${GROUP_CFG}" -H "Content-type: application/json" http://${MARKLOGIC_BOOTSTRAP_HOST}:8002/manage/v2/groups
                 fi    
               fi      
             fi
-            echo '### Init container execution completed ###'
+            log "Info: [initContainer] Init container execution completed"
         env: 
         - name: MARKLOGIC_GROUP
           value: {{ .Values.group.name }}

charts/values.yaml

@@ -24,7 +24,7 @@ image:
 # Init container image parameters
 initContainerImage:
   repository: curlimages/curl
-  tag: latest
+  tag: 7.85.0
   pullPolicy: IfNotPresent
 
 # Configure the imagePullSecret to pull the image from private repository that requires credential