updated tests and added comments in values file for updateStrategy

Author: Barkha Choithani

charts/values.yaml

@@ -4,6 +4,8 @@
 replicaCount: 1
 
 # update strategy for MarkLogic and Helm chart upgrades
+# It is recommended to use OnDelete updateStrategy as MarkLogic bootstrap host (pod-0) needs to be upgraded first in the cluster.
+# and onDelete allows more control over the upgrade and recovery incase of failure.
 updateStrategy:  
     type: OnDelete
 
@@ -23,7 +25,7 @@ bootstrapHostName: ""
 # Marklogic image parameters
 image:
   repository: marklogicdb/marklogic-db
-  tag: latest
+  tag: latest-10.0
   pullPolicy: IfNotPresent
 
 # Init container image parameters
@@ -55,7 +57,7 @@ fullnameOverride: ""
 # Configure Marklogic Admin Username and Password
 auth:
   adminUsername: admin
-  adminPassword: ""
+  adminPassword: admin
 
 # Configure Affinity property for scheduling pods to nodes
 # ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity
@@ -70,7 +72,7 @@ nodeSelector: {}
 # The "" storageClass will use the default storage class for your cluster. (gp2 for EKS, standard for Minikube)
 # If set the enabled to false, it will use EmptyDir volume
 persistence:
-  enabled: true
+  enabled: false
   storageClass: ""
   size: 10Gi
   annotations: {}

test/e2e/upgrade_test.go

@@ -126,6 +126,7 @@ func TestMLupgrade(t *testing.T) {
 		SetValues: map[string]string{
 			"persistence.enabled": "false",
 			"replicaCount":        "1",
+			"updateStrategy.type": "OnDelete",
 			"image.repository":    "marklogicdb/marklogic-db",
 			"image.tag":           "latest-10.0",
 			"auth.adminUsername":  username,
@@ -160,10 +161,10 @@ func TestMLupgrade(t *testing.T) {
 	t.Logf("====Upgrading Helm Chart")
 	helm.Upgrade(t, newOptions, helmChartPath, releaseName)
 
-	// Give time to change status of pod from running to terminate during upgrade
-	time.Sleep(10 * time.Second)
+	// delete pods to allow upgrades 
+	k8s.RunKubectl(t, kubectlOptions, "delete", "pod", podName)
 
-	// wait until second pod is in Ready status
+	// wait until pod is in Ready status with new configuration
 	k8s.WaitUntilPodAvailable(t, kubectlOptions, podName, 15, 30*time.Second)
 
 	tunnel := k8s.NewTunnel(