Skip to content

Commit c0b741d

Browse files
author
Romain Winieski
authored
Merge pull request #96 from marklogic/features/CLD-701-secret-as-file
CLD-701 pass admin user and password using file
2 parents c2a0515 + 96324b6 commit c0b741d

File tree

2 files changed

+43
-25
lines changed

2 files changed

+43
-25
lines changed

charts/templates/statefulset.yaml

Lines changed: 32 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,16 @@ spec:
2727
initContainers:
2828
- name: configure-group
2929
image: "{{ .Values.initContainerImage.repository }}:{{ .Values.initContainerImage.tag }}"
30+
volumeMounts:
31+
- name: mladmin-secrets
32+
mountPath: /run/secrets/ml-secrets
33+
readOnly: true
3034
command:
3135
- sh
3236
- '-c'
3337
- |
38+
MARKLOGIC_ADMIN_USERNAME="$(< /run/secrets/ml-secrets/username)"
39+
MARKLOGIC_ADMIN_PASSWORD="$(< /run/secrets/ml-secrets/password)"
3440
log () {
3541
local TIMESTAMP=$(date +"%Y-%m-%d %T.%3N")
3642
echo "${TIMESTAMP} $@"
@@ -69,16 +75,10 @@ spec:
6975
exit 1
7076
fi
7177
env:
72-
- name: MARKLOGIC_ADMIN_USERNAME
73-
valueFrom:
74-
secretKeyRef:
75-
name: {{ include "marklogic.fullname" . }}-admin
76-
key: username
77-
- name: MARKLOGIC_ADMIN_PASSWORD
78-
valueFrom:
79-
secretKeyRef:
80-
name: {{ include "marklogic.fullname" . }}-admin
81-
key: password
78+
- name: MARKLOGIC_ADMIN_USERNAME_FILE
79+
value: "ml-secrets/username"
80+
- name: MARKLOGIC_ADMIN_PASSWORD_FILE
81+
value: "ml-secrets/password"
8282
- name: POD_NAME
8383
valueFrom:
8484
fieldRef:
@@ -92,6 +92,9 @@ spec:
9292
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
9393
imagePullPolicy: {{ .Values.image.pullPolicy}}
9494
volumeMounts:
95+
- name: mladmin-secrets
96+
mountPath: "/run/secrets/ml-secrets"
97+
readOnly: false
9598
- name: datadir
9699
mountPath: /var/opt/MarkLogic
97100
{{- if .Values.extraVolumeMounts }}
@@ -101,16 +104,10 @@ spec:
101104
mountPath: /run/secrets/ml-secrets
102105
readOnly: true
103106
env:
104-
- name: MARKLOGIC_ADMIN_USERNAME
105-
valueFrom:
106-
secretKeyRef:
107-
name: {{ include "marklogic.fullname" . }}-admin
108-
key: username
109-
- name: MARKLOGIC_ADMIN_PASSWORD
110-
valueFrom:
111-
secretKeyRef:
112-
name: {{ include "marklogic.fullname" . }}-admin
113-
key: password
107+
- name: MARKLOGIC_ADMIN_USERNAME_FILE
108+
value: "ml-secrets/username"
109+
- name: MARKLOGIC_ADMIN_PASSWORD_FILE
110+
value: "ml-secrets/password"
114111
{{- if .Values.auth.walletPassword }}
115112
- name: MARKLOGIC_WALLET_PASSWORD_FILE
116113
value: ml-secrets/wallet-password
@@ -152,6 +149,9 @@ spec:
152149
- bash
153150
- '-c'
154151
- |
152+
MARKLOGIC_ADMIN_USERNAME="$(< /run/secrets/ml-secrets/username)"
153+
MARKLOGIC_ADMIN_PASSWORD="$(< /run/secrets/ml-secrets/password)"
154+
155155
pid=$(pgrep start.marklogic)
156156
157157
log () {
@@ -185,6 +185,9 @@ spec:
185185
- bash
186186
- '-c'
187187
- |
188+
MARKLOGIC_ADMIN_USERNAME="$(< /run/secrets/ml-secrets/username)"
189+
MARKLOGIC_ADMIN_PASSWORD="$(< /run/secrets/ml-secrets/password)"
190+
188191
log () {
189192
local TIMESTAMP=$(date +"%Y-%m-%d %T.%3N")
190193
# Check to make sure pod doesn't terminate if PID value is empty for any reason
@@ -213,14 +216,14 @@ spec:
213216
214217
while (true)
215218
do
216-
ml_status=$(service MarkLogic status)
217-
log "Info: [prestop] MarkLogic Status: "$ml_status
218-
if [[ "$ml_status" =~ "running" ]]; then
219+
ml_status=$(service MarkLogic status)
220+
log "Info: [prestop] MarkLogic Status: "$ml_status
221+
if [[ "$ml_status" =~ "running" ]]; then
219222
sleep 5s
220223
continue
221-
else
224+
else
222225
break
223-
fi
226+
fi
224227
done
225228
break
226229
else
@@ -297,6 +300,9 @@ spec:
297300
imagePullSecrets:
298301
- name: {{ include "marklogic.fullname" . }}-registry
299302
{{- end }}
303+
dnsConfig:
304+
searches:
305+
- {{ include "marklogic.headlessURL" . }}
300306
volumes:
301307
- name: mladmin-secrets
302308
secret:
@@ -341,6 +347,7 @@ spec:
341347
resources:
342348
requests:
343349
storage: {{ .Values.persistence.size }}
350+
{{- end }}
344351
{{- if .Values.additionalVolumeClaimTemplates }}
345352
{{- toYaml .Values.additionalVolumeClaimTemplates | nindent 4 }}
346353
{{- end }}

charts/values.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,17 @@ service:
142142
annotations: {}
143143

144144
type: ClusterIP
145+
ports:
146+
- protocol: TCP
147+
name: query-console
148+
port: 8000
149+
- protocol: TCP
150+
name: admin
151+
port: 8001
152+
- protocol: TCP
153+
name: manage
154+
port: 8002
155+
145156
## Service listener port configuration
146157
## ref: https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/
147158

0 commit comments

Comments
 (0)