MLE-21691: fix bug for service not updated when added new port #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that existing Kubernetes Service resources are updated when new ports are added by introducing patch-based diffing and refactoring service generation.
- Use k8s-objectmatcher to calculate and apply patches in
ReconcileServices, updating Services when specs differ. - Add
StsNametoserviceParametersand switch selector logic togetSelectorLabels(params.StsName). - Remove deprecated helper methods (
getService,CreateOrUpdateService) and refine import and label merging logic.
Comments suppressed due to low confidence (4)
pkg/k8sutil/service.go:18
- [nitpick] The field name 'StsName' is an unclear abbreviation; consider renaming it to 'StatefulSetName' for clarity.
StsName string
pkg/k8sutil/service.go:106
- [nitpick] The declaration of svcParams could be simplified by directly using a short variable declaration (e.g.,
svcParams := generateServiceParams(cr)), removing the redundant zero-value initialization.
var svcParams serviceParameters = serviceParameters{}
pkg/k8sutil/service.go:125
- Consider adding unit or integration tests for the service reconciliation logic, especially covering the update path when new ports are added to verify the patch and update behavior.
svcDef := generateService(service, cr)
pkg/k8sutil/service.go:17
- Add a doc comment for the
StsNamefield inserviceParametersto explain its purpose and usage.
type serviceParameters struct {
| import ( | ||
| "strings" | ||
|
|
||
| "github.com/cisco-open/k8s-objectmatcher/patch" |
There was a problem hiding this comment.
[nitpick] Consider reorganizing imports to follow the project's style guide (e.g., grouping standard library, third-party, and local imports separately) for consistency.
rwinieski
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.