MLE-24402 Removing deprecated fileRows.documentType option #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated spark.marklogic.write.fileRows.documentType option that was deprecated in version 2.3.0, replacing it with the unified spark.marklogic.write.documentType option. Additionally, it addresses compiler warnings and enables stricter compilation settings to prevent future warnings.
- Removed deprecated
WRITE_FILE_ROWS_DOCUMENT_TYPEoption and related code - Updated tests and documentation to use
WRITE_DOCUMENT_TYPEinstead - Added compiler flags to treat warnings as errors and fixed existing warnings
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WriteFileRowsTest.java | Updated test methods to use new option and removed deprecation annotations |
| AbstractIntegrationTest.java | Fixed generic type warning in method signature |
| marklogic-spark-messages.properties | Removed deprecated option from properties file |
| WriteContext.java | Removed deprecated method for handling old option |
| FileRowConverter.java | Removed deprecated option handling and updated comment |
| Options.java | Removed deprecated constant definition |
| build.gradle | Added compiler flags for warnings and fixed property assignment warnings |
| writing.md | Updated documentation to reference new option |
| generic-file-support.md | Updated documentation to reference new option |
| configuration.md | Updated configuration table with new option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
rjrudin
force-pushed
the
feature/remove-deprecated-options
branch
2 times, most recently
from
ad960a6 to
4a658d7
Compare
rjrudin
changed the title
rjrudin
force-pushed
the
feature/remove-deprecated-options
branch
from
4a658d7 to
b2168f5
Compare
BillFarber
approved these changes
Sep 23, 2025
Contributor
BillFarber
left a comment
BillFarber
left a comment
There was a problem hiding this comment.
Assuming the connection failure in the tests is transitory.
Deprecated in 2.3.0, can be removed for 3.0.0
rjrudin
force-pushed
the
feature/remove-deprecated-options
branch
from
b2168f5 to
0d2610d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in 2.3.0, can be removed for 3.0.0