Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Sep 24, 2025

This is to match Flux, which is depending on Hadoop 3.4.2.

Also fixed all compiler warnings, so enabling those as errors now.

Copilot AI review requested due to automatic review settings September 24, 2025 15:51
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Copyright Validation Results
Total: 3 | Passed: 1 | Failed: 0 | Skipped: 2 | at: 2025-09-24 17:27:51 UTC | commit: 4f52036

⏭️ Skipped (Excluded) Files

  • build.gradle
  • marklogic-spark-connector/build.gradle

✅ Valid Files

  • marklogic-spark-connector/src/test/java/com/marklogic/spark/AbstractIntegrationTest.java

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Hadoop dependency to version 3.4.2 to match Flux's dependency version, while also enabling compiler warnings as errors to maintain code quality.

  • Upgraded Hadoop dependency to version 3.4.2
  • Fixed all existing compiler warnings
  • Enabled treating compiler warnings as errors

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
marklogic-spark-connector/src/test/java/com/marklogic/spark/AbstractIntegrationTest.java Added generic type parameter to DataFrameWriter to fix unchecked type warning
marklogic-spark-connector/build.gradle Added compiler warning configuration, fixed Gradle syntax deprecations, and updated JVM args syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

tasks.withType(JavaCompile) {
options.compilerArgs += ["-Xlint:unchecked", "-Xlint:deprecation", "-Werror"]
options.deprecation = true
options.warnings = true
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options.warnings = true setting is redundant since warnings are already enabled by default in Gradle. The -Xlint flags on line 150 are sufficient for enabling specific warning categories.

Suggested change
options.warnings = true

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin force-pushed the feature/compiler-warnings branch from be286c4 to 7371b08 Compare September 24, 2025 17:19
This is to match Flux, which is depending on Hadoop 3.4.2.

Also fixed all compiler warnings, so enabling those as errors now.
@rjrudin rjrudin force-pushed the feature/compiler-warnings branch from 7371b08 to 4f52036 Compare September 24, 2025 17:27
@sonarqube-progress-marklogic
Copy link

@rjrudin rjrudin merged commit a8a4d40 into develop Sep 24, 2025
4 checks passed
@rjrudin rjrudin deleted the feature/compiler-warnings branch September 24, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants