-
Notifications
You must be signed in to change notification settings - Fork 6
MLE-24374 Now using server-specific default namespace for embeddings #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the default namespace for embedding elements in XML documents from the generic model namespace to a MarkLogic-specific vector namespace. The change aligns the connector with the server's default vector namespace behavior.
- Updated the default embedding namespace from
http://marklogic.com/appservices/modeltohttp://marklogic.com/vector - Modified XML chunk configuration to use the new vector namespace by default
- Updated test expectations to reflect the namespace change from
model:embeddingtovec:embedding
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Util.java | Introduces DEFAULT_VECTOR_NAMESPACE constant for the new MarkLogic vector namespace |
| Options.java | Updates documentation to clarify the new default namespace behavior as of version 3.0.0 |
| ChunkConfig.java | Simplifies embedding namespace logic to default to the vector namespace |
| XmlChunkConfig.java | Changes default embedding namespace from model to vector namespace |
| NamespaceContextFactory.java | Adds vector namespace prefix mapping for XPath operations |
| AbstractIntegrationTest.java | Registers the new vector namespace prefix for test XML parsing |
| AddEmbeddingsToXmlTest.java | Updates test assertions and comments to expect vec:embedding elements |
| xml-vector-chunks.json | Updates TDE template to use vector namespace for embedding extraction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| for (XmlNode chunk : doc.getXmlNodes("/root/model:chunks/model:chunk")) { | ||
| String embeddingValue = chunk.getElementValue("/model:chunk/model:embedding"); | ||
| System.out.println(chunk.getPrettyXml()); |
Copilot
AI
Sep 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug print statement should be removed before merging to production. This appears to be leftover debugging code that will clutter the test output.
| System.out.println(chunk.getPrettyXml()); |
66f96e9 to
ef171d4
Compare
ef171d4 to
40b51c9
Compare
|




No description provided.