-
Notifications
You must be signed in to change notification settings - Fork 6
MLE-24826 Bumping Spring, Spark, and ml-gradle #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Spring and Spark dependencies to newer versions and integrates ml-gradle 6.2-SNAPSHOT. The changes include version bumps for Spark (4.1.0-preview2), Spring dependencies via ml-app-deployer and marklogic-junit5 upgrades, and Jenkins pipeline improvements using the new mlWaitTillReady task.
- Upgraded Spark from 4.1.0-preview1 to 4.1.0-preview2
- Updated ml-gradle from 6.0.1 to 6.2-SNAPSHOT with corresponding dependency updates
- Refactored Jenkins pipeline to use
mlWaitTillReadyand consolidated cleanup logic
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-app/build.gradle | Migrated from plugin DSL to buildscript block to use ml-gradle 6.2-SNAPSHOT |
| marklogic-spark-connector/build.gradle | Updated dependency versions including Spark, JUnit, ml-app-deployer, and removed dependency exclusions |
| gradle.properties | Bumped Spark version to 4.1.0-preview2 |
| Jenkinsfile | Refactored test execution with mlWaitTillReady, extracted teardown logic, and removed hardcoded sleep |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Jenkinsfile
Outdated
| export JAVA_HOME=$JAVA17_HOME_DIR | ||
| export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR | ||
| export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH | ||
| export PATH=$$JAVA_HOME/bin:$PATH |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double dollar sign $$JAVA_HOME will not correctly expand the environment variable. Should be $JAVA_HOME (single dollar sign).
| export PATH=$$JAVA_HOME/bin:$PATH | |
| export PATH=$JAVA_HOME/bin:$PATH |
0928829 to
4ea96d7
Compare
And also trying out mlWaitTillReady, plus some general Jenkins cleanup.
4ea96d7 to
39f7917
Compare
|




And also trying out mlWaitTillReady, plus some general Jenkins cleanup.