Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Nov 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 7, 2025 13:39
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Copyright Validation Results
Total: 3 | Passed: 0 | Failed: 0 | Skipped: 3 | at: 2025-11-12 17:52:19 UTC | commit: 5920f46

⏭️ Skipped (Excluded) Files

  • Jenkinsfile
  • build.gradle
  • test-app/build.gradle

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout configuration for MarkLogic availability checks in Jenkins CI environments to address intermittent timing issues during deployment.

Key Changes:

  • Increased the mlWaitTillReady max attempts from default (60) to 40 explicit attempts
  • Added an additional mlWaitTillReady check with a 3-second sleep in the Jenkins pipeline
  • Updated the net.saliman.properties plugin from version 1.5.2 to 1.6.0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test-app/build.gradle Configured mlWaitTillReady with 40 max attempts and upgraded properties plugin to 1.6.0
Jenkinsfile Added sleep and duplicate mlWaitTillReady call to ensure MarkLogic availability before deployment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


apply plugin: "com.marklogic.ml-gradle"

// Sometimes, 3 x 20 isn't enough on Jenkins.
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references '3 x 20' but the code sets maxAttempts to 40. This creates confusion about the actual timeout calculation. Update the comment to accurately reflect the new configuration, such as '// Sometimes, the default timeout isn't enough on Jenkins, so increasing to 40 attempts.'

Suggested change
// Sometimes, 3 x 20 isn't enough on Jenkins.
// Sometimes, the default timeout isn't enough on Jenkins, so increasing to 40 attempts.

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin force-pushed the feature/jenkins-tweak branch from 1b1ed0a to 5920f46 Compare November 12, 2025 17:52
@sonarqube-progress-marklogic
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rjrudin rjrudin merged commit 0ebe9be into develop Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants