#377 Deprecating support for creating forests on one host automatically

This is better achieved explicitly via mlDatabasesWithForestsOnOneHost

Author: rjrudin

src/main/java/com/marklogic/appdeployer/DefaultAppConfigFactory.java

@@ -839,6 +839,14 @@ protected ConfigDir buildConfigDir(String path) {
 		return new ConfigDir(baseDir);
 	}
 
+	/**
+	 * This was added in 3.11.0 to mirror the functionality of the now-deprecated DeployTriggersDatabaseCommand and
+	 * DeploySchemasDatabaseCommand classes. But the mlDatabasesWithForestsOnOneHost property is the better way of
+	 * handling this so that it's explicitly configured, rather than happening magically via setting mlAppName.
+	 *
+	 * @param appConfig
+	 */
+	@Deprecated
 	protected void setDefaultsForDatabasesWithForestsOnOneHost(AppConfig appConfig) {
 		Set<String> set = appConfig.getDatabasesWithForestsOnOneHost();
 		if (set == null || set.isEmpty()) {

src/test/java/com/marklogic/appdeployer/DefaultAppConfigFactoryTest.java

@@ -552,6 +552,10 @@ public void mlUsernameAndPassword() {
 		assertNull("SSL hostname verifier should be null by default", config.getRestSslHostnameVerifier());
 	}
 
+	/**
+	 * See notes on the method that's deprecated, should be removed in ml-app-deployer 4.0.
+	 */
+	@Deprecated
 	@Test
 	public void schemasAndTriggerDatabaseNamesShouldBeInSetOfDatabasesWithForestsOnOneHost() {
 		sut = new DefaultAppConfigFactory(new SimplePropertySource("mlAppName", "example"));