#388 Invalid property values are reported with a helpful message

Author: rjrudin

src/main/java/com/marklogic/appdeployer/DefaultAppConfigFactory.java

@@ -33,7 +33,12 @@ public AppConfig newAppConfig() {
 		for (String propertyName : propertyConsumerMap.keySet()) {
 			String value = getProperty(propertyName);
 			if (value != null) {
-				propertyConsumerMap.get(propertyName).accept(appConfig, value);
+				try {
+					propertyConsumerMap.get(propertyName).accept(appConfig, value);
+				} catch (Exception ex) {
+					throw new IllegalArgumentException(
+						format("Unable to parse value '%s' for property '%s'; cause: %s", value, propertyName, ex.getMessage()), ex);
+				}
 			}
 		}
 

src/test/java/com/marklogic/appdeployer/DefaultAppConfigFactoryTest.java

@@ -72,6 +72,21 @@ public void withProjectDirAndDefaultPaths() {
 		assertEquals(projectPath + "/src/main/ml-schemas", appConfig.getSchemaPaths().get(0));
 	}
 
+	@Test
+	public void invalidPropertyValue() {
+		sut = new DefaultAppConfigFactory(new SimplePropertySource("mlForestsPerHost", "3"));
+		try {
+			sut.newAppConfig();
+			fail("The call should have failed because the property has an invalid value; it's expecting 'forestName,value'");
+		} catch (IllegalArgumentException ex) {
+			String message = ex.getMessage();
+			assertTrue(
+				"Expected the exception to identify the property name and value; message: " + message,
+				message.startsWith("Unable to parse value '3' for property 'mlForestsPerHost'")
+			);
+		}
+	}
+
 	@Test
 	public void trimProperties() {
 		sut = new DefaultAppConfigFactory(new SimplePropertySource("mlHost", "  has-spaces   ", "mlUsername", "has spaces"));