Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Commit f52d89b

Browse files
committed
#401 logback is now a compileOnly dependency
This avoids issues with reusing ml-app-deployer in environments where bundling logback can cause mysterious problems
1 parent d762365 commit f52d89b

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

build.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,15 @@ dependencies {
4141

4242
// Don't want to include this in the published jar, just the executable jar
4343
compileOnly "com.beust:jcommander:1.78"
44+
compileOnly "ch.qos.logback:logback-classic:1.2.3"
4445

45-
testImplementation 'com.marklogic:ml-junit:3.2.0'
46+
testImplementation 'com.marklogic:ml-junit:3.2.0'
4647
// Force ml-junit to use 5.2.8 instead of 4.1.5
4748
testImplementation "org.springframework:spring-test:5.2.9.RELEASE"
4849
testImplementation 'commons-io:commons-io:2.8.0'
4950

50-
// Forcing Spring to use logback instead of commons-logging
51-
implementation "ch.qos.logback:logback-classic:1.2.3" // Needs to be implementation for CLI
51+
// Forcing Spring to use logback for testing instead of commons-logging
52+
testImplementation "ch.qos.logback:logback-classic:1.2.3"
5253
testImplementation group: "org.slf4j", name: "jcl-over-slf4j", version: "1.7.30"
5354
testImplementation group: "org.slf4j", name: "slf4j-api", version: "1.7.30"
5455
}

gradle.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@ group=com.marklogic
22
javadocsDir=../gh-pages-marklogic-java/javadocs
33
version=4.1.0-SNAPSHOT
44

5+
snykToken=
6+

0 commit comments

Comments
 (0)