#149 Not setting default params when doing a COPY

Author: Rob Rudin

examples/mlcp-project/build.gradle

@@ -10,7 +10,7 @@ buildscript {
 		mavenLocal()
 	}
 	dependencies {
-		classpath "com.marklogic:ml-gradle:2.4.0"
+		classpath "com.marklogic:ml-gradle:2.5.0"
 	}
 }
 
@@ -119,3 +119,21 @@ task exportSampleData(type: com.marklogic.gradle.task.MlcpTask) {
 	output_file_path = "data/export"
 	collection_filter = "sample-import"
 }
+
+/**
+ * Example of a COPY task. In this case, MlcpTask won't populate host/port/username/password, since the arguments have
+ * different names for a COPY, and it's not clear what their values should default to.
+ */
+task copySampleData(type: com.marklogic.gradle.task.MlcpTask) {
+	description = "Copy the sample data from the app-specific database to Documents"
+	classpath = configurations.mlcp
+	command = "COPY"
+	input_host = mlHost
+	input_port = Integer.parseInt(mlRestPort)
+	input_username = mlUsername
+	input_password = mlPassword
+	output_host = mlHost
+	output_port = 8000
+	output_username = mlUsername
+	output_password = mlPassword
+}

src/main/groovy/com/marklogic/gradle/task/MlcpTask.groovy

@@ -20,71 +20,77 @@ import com.marklogic.appdeployer.AppConfig
  */
 class MlcpTask extends JavaExec {
 
-    @Delegate MlcpBean mlcpBean = new MlcpBean();
-
-    public Logger getLogger() {
-        return Logging.getLogger(MlcpTask.class)
-    }
-
-    @TaskAction
-    @Override
-    public void exec() {
-        setMain("com.marklogic.contentpump.ContentPump")
-        AppConfig config = getProject().property("mlAppConfig")
-
-        List<String> newArgs = new ArrayList<>()
-        newArgs.add(command)
-
-        mlcpBean.properties.each { prop, val ->
-            def propVal
-            if (val) {
-                switch (prop) {
-                    case "host":
-                        propVal = (val ? val : config.getHost())
-                        break
-                    case "port":
-                        propVal = (val ? val : 8000)
-                        break
-                    case "username":
-                        propVal = (val ? val : config.getRestAdminUsername())
-                        break
-                    case ["class", "logger", "command", "password"]:
-                        // skip for now
-                        return
-                    default:
-                        propVal = val
-                        break
-                }
-
-                newArgs.add("-" + prop);
-                newArgs.add(String.valueOf(propVal));
-            }
-        }
-
-		// Ensure connection arguments are present
-		if (!newArgs.contains("-host")) {
-			newArgs.add("-host")
-			newArgs.add(config.getHost())
+	@Delegate
+	MlcpBean mlcpBean = new MlcpBean();
+
+	public Logger getLogger() {
+		return Logging.getLogger(MlcpTask.class)
+	}
+
+	@TaskAction
+	@Override
+	public void exec() {
+		setMain("com.marklogic.contentpump.ContentPump")
+		AppConfig config = getProject().property("mlAppConfig")
+
+		List<String> newArgs = new ArrayList<>()
+		newArgs.add(command)
+
+		mlcpBean.properties.each { prop, val ->
+			def propVal
+			if (val) {
+				switch (prop) {
+					case "host":
+						propVal = (val ? val : config.getHost())
+						break
+					case "port":
+						propVal = (val ? val : 8000)
+						break
+					case "username":
+						propVal = (val ? val : config.getRestAdminUsername())
+						break
+					case ["class", "logger", "command", "password"]:
+						// skip for now
+						return
+					default:
+						propVal = val
+						break
+				}
+
+				newArgs.add("-" + prop);
+				newArgs.add(String.valueOf(propVal));
+			}
 		}
-		if (!newArgs.contains("-port")) {
-			newArgs.add("-port")
-			newArgs.add("8000")
-		}
-		if (!newArgs.contains("-username")) {
-			newArgs.add("-username")
-			newArgs.add(config.getRestAdminUsername())
+
+		// Ensure connection arguments are present, but not if a COPY
+		boolean isCopy = "COPY".equals(command)
+		if (!isCopy) {
+			if (!newArgs.contains("-host")) {
+				newArgs.add("-host")
+				newArgs.add(config.getHost())
+			}
+			if (!newArgs.contains("-port")) {
+				newArgs.add("-port")
+				newArgs.add("8000")
+			}
+			if (!newArgs.contains("-username")) {
+				newArgs.add("-username")
+				newArgs.add(config.getRestAdminUsername())
+			}
 		}
 
 		println "mlcp arguments, excluding password: " + newArgs
 
-        newArgs.add("-password")
-        newArgs.add(password ? password : config.getRestAdminPassword())
+		if (!isCopy) {
+			newArgs.add("-password")
+			newArgs.add(password ? password : config.getRestAdminPassword())
+		}
 
 		// Include any args that a user has configured via the args parameter of the Gradle task
 		newArgs.addAll(getArgs())
 
-        setArgs(newArgs)
+		setArgs(newArgs)
 
-        super.exec()
-    }
+		super.exec()
+	}
 }